From d61f8a1e7053c5f5003f916e68c24ccc116485ca Mon Sep 17 00:00:00 2001
From: vlad <vlad@driver.xyz>
Date: Sat, 24 Mar 2018 13:47:22 -0700
Subject: Correct `trackingId` placement to the MDC

---
 .../scala/xyz/driver/core/rest/DriverRoute.scala     | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/src/main/scala/xyz/driver/core/rest/DriverRoute.scala b/src/main/scala/xyz/driver/core/rest/DriverRoute.scala
index 674a0c4..8878ef4 100644
--- a/src/main/scala/xyz/driver/core/rest/DriverRoute.scala
+++ b/src/main/scala/xyz/driver/core/rest/DriverRoute.scala
@@ -26,7 +26,13 @@ trait DriverRoute {
 
   protected def defaultResponseHeaders: Directive0 = {
     extractRequest flatMap { request =>
-      val tracingHeader = RawHeader(ContextHeaders.TrackingIdHeader, rest.extractTrackingId(request))
+
+      // Needs to happen before any request processing, so all the log messages
+      // associated with processing of this request are having this `trackingId`
+      val trackingId = rest.extractTrackingId(request)
+      val tracingHeader = RawHeader(ContextHeaders.TrackingIdHeader, trackingId)
+      MDC.put("trackingId", trackingId)
+
       respondWithHeader(tracingHeader)
     }
   }
@@ -43,13 +49,12 @@ trait DriverRoute {
     case is: IllegalStateException =>
       ctx =>
         log.warn(s"Request is not allowed to ${ctx.request.method} ${ctx.request.uri}", is)
-        errorResponse(ctx, StatusCodes.BadRequest, message = is.getMessage, is)(ctx)
+        errorResponse(StatusCodes.BadRequest, message = is.getMessage, is)(ctx)
 
     case cm: ConcurrentModificationException =>
       ctx =>
         log.warn(s"Concurrent modification of the resource ${ctx.request.method} ${ctx.request.uri}", cm)
         errorResponse(
-          ctx,
           StatusCodes.Conflict,
           "Resource was changed concurrently, try requesting a newer version",
           cm)(ctx)
@@ -57,12 +62,12 @@ trait DriverRoute {
     case se: SQLException =>
       ctx =>
         log.warn(s"Database exception for the resource ${ctx.request.method} ${ctx.request.uri}", se)
-        errorResponse(ctx, StatusCodes.InternalServerError, "Data access error", se)(ctx)
+        errorResponse(StatusCodes.InternalServerError, "Data access error", se)(ctx)
 
     case t: Exception =>
       ctx =>
         log.warn(s"Request to ${ctx.request.method} ${ctx.request.uri} could not be handled normally", t)
-        errorResponse(ctx, StatusCodes.InternalServerError, t.getMessage, t)(ctx)
+        errorResponse(StatusCodes.InternalServerError, t.getMessage, t)(ctx)
   }
 
   protected def serviceExceptionHandler(serviceException: ServiceException): Route = {
@@ -88,17 +93,14 @@ trait DriverRoute {
     }
 
     { (ctx: RequestContext) =>
-      errorResponse(ctx, statusCode, serviceException.message, serviceException)(ctx)
+      errorResponse(statusCode, serviceException.message, serviceException)(ctx)
     }
   }
 
   protected def errorResponse[T <: Exception](
-      ctx: RequestContext,
       statusCode: StatusCode,
       message: String,
       exception: T): Route = {
-    val trackingId = rest.extractTrackingId(ctx.request)
-    MDC.put("trackingId", trackingId)
     complete(HttpResponse(statusCode, entity = message))
   }
 }
-- 
cgit v1.2.3


From 530f781a3d1a30dd381e16e8ee67becad2f17f07 Mon Sep 17 00:00:00 2001
From: vlad <vlad@driver.xyz>
Date: Mon, 26 Mar 2018 01:21:45 -0700
Subject: Correct `trackingId` placement to the MDC

---
 src/main/scala/xyz/driver/core/rest/DriverRoute.scala | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/src/main/scala/xyz/driver/core/rest/DriverRoute.scala b/src/main/scala/xyz/driver/core/rest/DriverRoute.scala
index 8878ef4..c23c44d 100644
--- a/src/main/scala/xyz/driver/core/rest/DriverRoute.scala
+++ b/src/main/scala/xyz/driver/core/rest/DriverRoute.scala
@@ -26,10 +26,9 @@ trait DriverRoute {
 
   protected def defaultResponseHeaders: Directive0 = {
     extractRequest flatMap { request =>
-
       // Needs to happen before any request processing, so all the log messages
       // associated with processing of this request are having this `trackingId`
-      val trackingId = rest.extractTrackingId(request)
+      val trackingId    = rest.extractTrackingId(request)
       val tracingHeader = RawHeader(ContextHeaders.TrackingIdHeader, trackingId)
       MDC.put("trackingId", trackingId)
 
@@ -54,10 +53,8 @@ trait DriverRoute {
     case cm: ConcurrentModificationException =>
       ctx =>
         log.warn(s"Concurrent modification of the resource ${ctx.request.method} ${ctx.request.uri}", cm)
-        errorResponse(
-          StatusCodes.Conflict,
-          "Resource was changed concurrently, try requesting a newer version",
-          cm)(ctx)
+        errorResponse(StatusCodes.Conflict, "Resource was changed concurrently, try requesting a newer version", cm)(
+          ctx)
 
     case se: SQLException =>
       ctx =>
@@ -97,10 +94,7 @@ trait DriverRoute {
     }
   }
 
-  protected def errorResponse[T <: Exception](
-      statusCode: StatusCode,
-      message: String,
-      exception: T): Route = {
+  protected def errorResponse[T <: Exception](statusCode: StatusCode, message: String, exception: T): Route = {
     complete(HttpResponse(statusCode, entity = message))
   }
 }
-- 
cgit v1.2.3