From c1b9c1f53a6bb3f62abc7141e6b6153d8208e1f0 Mon Sep 17 00:00:00 2001 From: Kevin Wright Date: Thu, 8 Feb 2018 21:20:53 +0000 Subject: post-review changes --- examples/shared/src/main/scala/decode.scala | 8 ++++---- examples/shared/src/main/scala/show.scala | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) (limited to 'examples') diff --git a/examples/shared/src/main/scala/decode.scala b/examples/shared/src/main/scala/decode.scala index 9e91d17..539e478 100644 --- a/examples/shared/src/main/scala/decode.scala +++ b/examples/shared/src/main/scala/decode.scala @@ -10,10 +10,10 @@ trait Decoder[T] { def decode(str: String): T } object Decoder { /** decodes strings */ - implicit val string: Decoder[String] = (str: String) => str + implicit val string: Decoder[String] = (s: String) => s /** decodes ints */ - implicit val int: Decoder[Int] = (str: String) => str.toInt + implicit val int: Decoder[Int] = _.toInt /** binds the Magnolia macro to this derivation object */ implicit def gen[T]: Decoder[T] = macro Magnolia.gen[T] @@ -22,7 +22,7 @@ object Decoder { type Typeclass[T] = Decoder[T] /** defines how new [[Decoder]]s for case classes should be constructed */ - def combine[T](ctx: CaseClass[Decoder, T]): Decoder[T] = (value: String) => { + def combine[T](ctx: CaseClass[Decoder, T]): Decoder[T] = value => { val (_, values) = parse(value) ctx.construct { param => param.typeclass.decode(values(param.label)) @@ -30,7 +30,7 @@ object Decoder { } /** defines how to choose which subtype of the sealed trait to use for decoding */ - def dispatch[T](ctx: SealedTrait[Decoder, T]): Decoder[T] = (param: String) => { + def dispatch[T](ctx: SealedTrait[Decoder, T]): Decoder[T] = param => { val (name, _) = parse(param) val subtype = ctx.subtypes.find(_.typeName.full == name).get subtype.typeclass.decode(param) diff --git a/examples/shared/src/main/scala/show.scala b/examples/shared/src/main/scala/show.scala index 9afc4c9..ecf1dec 100644 --- a/examples/shared/src/main/scala/show.scala +++ b/examples/shared/src/main/scala/show.scala @@ -20,7 +20,7 @@ trait GenericShow[Out] { /** creates a new [[Show]] instance by labelling and joining (with `mkString`) the result of * showing each parameter, and prefixing it with the class name */ - def combine[T](ctx: CaseClass[Typeclass, T]): Show[Out, T] = (value: T) => { + def combine[T](ctx: CaseClass[Typeclass, T]): Show[Out, T] = { value => if (ctx.isValueClass) { val param = ctx.parameters.head param.typeclass.show(param.dereference(value)) -- cgit v1.2.3