From 1bec76f04cbaee8c48fecb2c21ff1015f398caf5 Mon Sep 17 00:00:00 2001 From: Yilun Chong Date: Wed, 1 Aug 2018 13:24:54 -0700 Subject: fix --- js/binary/reader_test.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/js/binary/reader_test.js b/js/binary/reader_test.js index 28f135bf..e1e6efa1 100644 --- a/js/binary/reader_test.js +++ b/js/binary/reader_test.js @@ -679,8 +679,13 @@ describe('binaryReaderTest', function() { writer.writeInt32(5, sentinel); var dummyMessage = /** @type {!jspb.BinaryMessage} */({}); writer.writeGroup(5, dummyMessage, function() { - writer.writeInt64(42, 42); + // Previously the skipGroup implementation was wrong, which only consume + // the decoder by nextField. This case is for making the previous + // implementation failed in skipGroup by an early end group tag. writer.writeInt64(44, 44); + writer.writeInt64(42, 42); + // This is for making the previous implementation failed by an invalid + // varint. writer.writeBytes(43, [255, 255, 255, 255, 255, 255, 255, 255, 255, 255]); writer.writeGroup(6, dummyMessage, function() { writer.writeInt64(84, 42); -- cgit v1.2.3