diff options
| author | Som Snytt <som.snytt@gmail.com> | 2016-12-10 13:47:34 -0800 |
|---|---|---|
| committer | Som Snytt <som.snytt@gmail.com> | 2017-03-11 23:48:32 -0800 |
| commit | d0ff0907e0cef7cd8defba12416e902e49e9f9e6 (patch) | |
| tree | bd31618195852451a64430a69a25930fb8306063 | |
| parent | 833724b131f86b978f0831f637d386d7ca37a2aa (diff) | |
| download | scala-d0ff0907e0cef7cd8defba12416e902e49e9f9e6.tar.gz scala-d0ff0907e0cef7cd8defba12416e902e49e9f9e6.tar.bz2 scala-d0ff0907e0cef7cd8defba12416e902e49e9f9e6.zip | |
SI-8040 Avoid Null companion
Don't warn on the private constructor of an abstract
class. Instead, take it as a signal that the class must
not be instantiated.
| -rw-r--r-- | src/compiler/scala/tools/nsc/typechecker/TypeDiagnostics.scala | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/compiler/scala/tools/nsc/typechecker/TypeDiagnostics.scala b/src/compiler/scala/tools/nsc/typechecker/TypeDiagnostics.scala index b30972f931..042c58226a 100644 --- a/src/compiler/scala/tools/nsc/typechecker/TypeDiagnostics.scala +++ b/src/compiler/scala/tools/nsc/typechecker/TypeDiagnostics.scala @@ -557,7 +557,7 @@ trait TypeDiagnostics { def isUnusedTerm(m: Symbol): Boolean = ( (m.isTerm) && (!m.isSynthetic || isSyntheticWarnable(m)) - && (m.isPrivate || m.isLocalToBlock) + && ((m.isPrivate && !(m.isConstructor && m.owner.isAbstract))|| m.isLocalToBlock) && !targets(m) && !(m.name == nme.WILDCARD) // e.g. val _ = foo && (m.isValueParameter || !ignoreNames(m.name.toTermName)) // serialization methods @@ -594,7 +594,7 @@ trait TypeDiagnostics { def apply(unit: CompilationUnit): Unit = if (warningsEnabled) { val p = new UnusedPrivates - p traverse unit.body + p.traverse(unit.body) if (settings.warnUnusedLocals || settings.warnUnusedPrivates) { for (defn: DefTree <- p.unusedTerms) { val sym = defn.symbol |