diff options
| author | Gregory Nutt <gnutt@nuttx.org> | 2013-10-24 07:21:56 -0600 |
|---|---|---|
| committer | Gregory Nutt <gnutt@nuttx.org> | 2013-10-24 07:21:56 -0600 |
| commit | 08f190c7ebb67f1b034fc39b393351de47b53a13 (patch) | |
| tree | 246dfd90d24bdc80c1e2cdd295d0fa308e482e3c | |
| parent | c4c5e3cee054900b6b9d7474b70904958391997c (diff) | |
| download | px4-nuttx-08f190c7ebb67f1b034fc39b393351de47b53a13.tar.gz px4-nuttx-08f190c7ebb67f1b034fc39b393351de47b53a13.tar.bz2 px4-nuttx-08f190c7ebb67f1b034fc39b393351de47b53a13.zip | |
Telnetd: Missing argument in debug statement can cause crash in certain error conditions. From David Sidrane
| -rw-r--r-- | apps/ChangeLog.txt | 3 | ||||
| -rw-r--r-- | apps/examples/cc3000/telnetd_driver.c | 2 | ||||
| -rw-r--r-- | apps/netutils/telnetd/telnetd_driver.c | 2 |
3 files changed, 5 insertions, 2 deletions
diff --git a/apps/ChangeLog.txt b/apps/ChangeLog.txt index df258de8c..8c9dd72a7 100644 --- a/apps/ChangeLog.txt +++ b/apps/ChangeLog.txt @@ -690,4 +690,7 @@ /dev/random (2013-10-20). * apps/examples/cc3000: Extensions and enhancements from David Sidrane (2013-10-23). + * apps/netutils/telnetd/telnetd_driver.c: Missing argument to + debug statement can cause crashes in certain error conditions. + From David Sidrane (2013-10-24). diff --git a/apps/examples/cc3000/telnetd_driver.c b/apps/examples/cc3000/telnetd_driver.c index c7d5c86ca..865dba1d3 100644 --- a/apps/examples/cc3000/telnetd_driver.c +++ b/apps/examples/cc3000/telnetd_driver.c @@ -504,7 +504,7 @@ static int telnetd_close(FAR struct file *filep) ret = unregister_driver(devpath); if (ret < 0) { - nlldbg("Failed to unregister the driver %s: %d\n", ret); + nlldbg("Failed to unregister the driver %s: %d\n", devpath, ret); } free(devpath); diff --git a/apps/netutils/telnetd/telnetd_driver.c b/apps/netutils/telnetd/telnetd_driver.c index 9128ad09b..13d1e00e4 100644 --- a/apps/netutils/telnetd/telnetd_driver.c +++ b/apps/netutils/telnetd/telnetd_driver.c @@ -505,7 +505,7 @@ static int telnetd_close(FAR struct file *filep) ret = unregister_driver(devpath); if (ret < 0) { - nlldbg("Failed to unregister the driver %s: %d\n", ret); + nlldbg("Failed to unregister the driver %s: %d\n", devpath, ret); } free(devpath); |