From c7b06385926349e10b3739314d1d56eec7efb8be Mon Sep 17 00:00:00 2001 From: Gregory Nutt Date: Thu, 11 Dec 2014 06:21:23 -0600 Subject: strncpy: Commit d0c76ccacf0dc8988f9617ad82bf4349f456bb08 will trash a lot of memory if n == 0. From Hiro --- nuttx/libc/string/lib_strncpy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nuttx/libc/string/lib_strncpy.c b/nuttx/libc/string/lib_strncpy.c index 8dfc899ce..5bd8ab237 100644 --- a/nuttx/libc/string/lib_strncpy.c +++ b/nuttx/libc/string/lib_strncpy.c @@ -51,7 +51,7 @@ char *strncpy(char *dest, const char *src, size_t n) char *ret = dest; /* Value to be returned */ char *end = dest + n; /* End of dest buffer + 1 byte */ - while ((*dest++ = *src++) != '\0' && dest != end); + while ((dest != end) && (*dest++ = *src++) != '\0'); while (dest != end) *dest++ = '\0'; return ret; } -- cgit v1.2.3