From 00dfdd7a897b2606ceeabf5323e71d8e80a446fc Mon Sep 17 00:00:00 2001 From: Cathy Yeh Date: Mon, 11 Dec 2017 11:39:04 -0800 Subject: PR comments --- beliefs/factors/bernoulli_and_cpd.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'beliefs/factors/bernoulli_and_cpd.py') diff --git a/beliefs/factors/bernoulli_and_cpd.py b/beliefs/factors/bernoulli_and_cpd.py index fb86135..fdb0c25 100644 --- a/beliefs/factors/bernoulli_and_cpd.py +++ b/beliefs/factors/bernoulli_and_cpd.py @@ -21,11 +21,11 @@ class BernoulliAndCPD(TabularCPD): parents=parents, parents_card=[2]*len(parents), values=[]) - self._values = [] + self._values = None @property def values(self): - if len(self._values) == 0: + if self._values is None: self._values = self._build_kwise_values_array(len(self.variables)) self._values = self._values.reshape(self.cardinality) return self._values @@ -37,6 +37,9 @@ class BernoulliAndCPD(TabularCPD): if k == 1: return np.array([0.5, 0.5]) + # values are stored as a row vector using an ordering such that + # the right-most variables as defined in [variable].extend(parents) + # cycle through their values the fastest. return np.array( [1.]*(2**(k-1)-1) + [0.] + [0.,]*(2**(k-1)-1) + [1.] ) -- cgit v1.2.3