From e07838aab7b059a37bfaa8ff23335cc6e1c9867e Mon Sep 17 00:00:00 2001 From: John St John Date: Tue, 26 Sep 2017 15:51:38 -0700 Subject: Catch and log google tracing exceptions rather than crashing the entire app --- ...ceptionLoggingSizedBufferingTraceConsumer.scala | 26 ++++++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 src/main/scala/xyz/driver/core/trace/ExceptionLoggingSizedBufferingTraceConsumer.scala (limited to 'src/main/scala/xyz/driver/core/trace/ExceptionLoggingSizedBufferingTraceConsumer.scala') diff --git a/src/main/scala/xyz/driver/core/trace/ExceptionLoggingSizedBufferingTraceConsumer.scala b/src/main/scala/xyz/driver/core/trace/ExceptionLoggingSizedBufferingTraceConsumer.scala new file mode 100644 index 0000000..534df8c --- /dev/null +++ b/src/main/scala/xyz/driver/core/trace/ExceptionLoggingSizedBufferingTraceConsumer.scala @@ -0,0 +1,26 @@ +package xyz.driver.core.trace + +import com.google.cloud.trace.v1.consumer.{FlushableTraceConsumer} +import com.google.devtools.cloudtrace.v1.Traces +import com.typesafe.scalalogging.Logger +import scala.util.Try + +/** + * ExceptionLoggingFlushableTraceConsumer simply wraps a flushable trace consumer and catches/logs any exceptions + * @param traceConsumer the flusable trace consumer to wrap + * @param log where to log any exceptions + */ +class ExceptionLoggingFlushableTraceConsumer(traceConsumer: FlushableTraceConsumer, log: Logger) + extends FlushableTraceConsumer { + + private val flushableTraceConsumer = traceConsumer + + private def exceptionLogger(exception: Throwable): Unit = + log.trace(s"Encountered exception logging to google $exception") + + override def receive(trace: Traces): Unit = + Try(flushableTraceConsumer.receive(trace)).fold(exceptionLogger, identity) + + override def flush(): Unit = + Try(flushableTraceConsumer.flush()).fold(exceptionLogger, identity) +} -- cgit v1.2.3 From 8a66e1a0e62187d850e665af0d17431272775705 Mon Sep 17 00:00:00 2001 From: John St John Date: Wed, 27 Sep 2017 11:20:39 -0700 Subject: log error as error --- .../driver/core/trace/ExceptionLoggingSizedBufferingTraceConsumer.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/main/scala/xyz/driver/core/trace/ExceptionLoggingSizedBufferingTraceConsumer.scala') diff --git a/src/main/scala/xyz/driver/core/trace/ExceptionLoggingSizedBufferingTraceConsumer.scala b/src/main/scala/xyz/driver/core/trace/ExceptionLoggingSizedBufferingTraceConsumer.scala index 534df8c..64ae15a 100644 --- a/src/main/scala/xyz/driver/core/trace/ExceptionLoggingSizedBufferingTraceConsumer.scala +++ b/src/main/scala/xyz/driver/core/trace/ExceptionLoggingSizedBufferingTraceConsumer.scala @@ -16,7 +16,7 @@ class ExceptionLoggingFlushableTraceConsumer(traceConsumer: FlushableTraceConsum private val flushableTraceConsumer = traceConsumer private def exceptionLogger(exception: Throwable): Unit = - log.trace(s"Encountered exception logging to google $exception") + log.error(s"Encountered exception logging to google $exception") override def receive(trace: Traces): Unit = Try(flushableTraceConsumer.receive(trace)).fold(exceptionLogger, identity) -- cgit v1.2.3