From 66cf166772712267aac922c51ded90c7dec3bdd5 Mon Sep 17 00:00:00 2001 From: Ivan Topolnjak Date: Tue, 12 Dec 2017 00:40:15 +0100 Subject: allow disabling/enabling metrics collection from the SpanBuilder --- kamon-core-tests/src/test/scala/kamon/trace/LocalSpanSpec.scala | 2 ++ kamon-core-tests/src/test/scala/kamon/trace/SpanMetrics.scala | 7 ++++++- 2 files changed, 8 insertions(+), 1 deletion(-) (limited to 'kamon-core-tests') diff --git a/kamon-core-tests/src/test/scala/kamon/trace/LocalSpanSpec.scala b/kamon-core-tests/src/test/scala/kamon/trace/LocalSpanSpec.scala index 5d636d16..21ad93b3 100644 --- a/kamon-core-tests/src/test/scala/kamon/trace/LocalSpanSpec.scala +++ b/kamon-core-tests/src/test/scala/kamon/trace/LocalSpanSpec.scala @@ -32,6 +32,8 @@ class LocalSpanSpec extends WordSpec with Matchers with BeforeAndAfterAll with E Kamon.buildSpan("test-span") .withTag("test", "value") .withStartTimestamp(100) + .disableMetrics() + .enableMetrics() .start() .finish(200) diff --git a/kamon-core-tests/src/test/scala/kamon/trace/SpanMetrics.scala b/kamon-core-tests/src/test/scala/kamon/trace/SpanMetrics.scala index ea29d92e..2a04024c 100644 --- a/kamon-core-tests/src/test/scala/kamon/trace/SpanMetrics.scala +++ b/kamon-core-tests/src/test/scala/kamon/trace/SpanMetrics.scala @@ -42,13 +42,18 @@ class SpanMetrics extends WordSpecLike with Matchers with MetricInspection with } - "not be recorded when disableMetrics() is called on the Span" in { + "not be recorded when disableMetrics() is called on the SpanBuilder or the Span" in { val operation = "span-with-disabled-metrics" buildSpan(operation) .start() .disableMetrics() .finish() + buildSpan(operation) + .disableMetrics() + .start() + .finish() + Span.Metrics.ProcessingTime.valuesForTag("operation") shouldNot contain(operation) } -- cgit v1.2.3