From 80f8a5d0b3a6c936453645254c1349b9691b1df2 Mon Sep 17 00:00:00 2001 From: Diego Date: Thu, 1 May 2014 19:49:22 -0300 Subject: ! core: first implementetion of kamon counter intrument and actor errors metrics --- .../akka/instrumentation/ActorMessagePassingTracing.scala | 11 ++++++----- .../scala/kamon/metrics/instruments/CounterRecorder.scala | 4 +++- 2 files changed, 9 insertions(+), 6 deletions(-) (limited to 'kamon-core/src/main') diff --git a/kamon-core/src/main/scala/akka/instrumentation/ActorMessagePassingTracing.scala b/kamon-core/src/main/scala/akka/instrumentation/ActorMessagePassingTracing.scala index ae9d20f6..78c170de 100644 --- a/kamon-core/src/main/scala/akka/instrumentation/ActorMessagePassingTracing.scala +++ b/kamon-core/src/main/scala/akka/instrumentation/ActorMessagePassingTracing.scala @@ -24,7 +24,6 @@ import kamon.metrics.{ ActorMetrics, Metrics } import kamon.Kamon import kamon.metrics.ActorMetrics.ActorMetricRecorder import java.util.concurrent.atomic.AtomicInteger -import kamon.metrics.instruments.Counter @Aspect class BehaviourInvokeTracing { @@ -33,7 +32,7 @@ class BehaviourInvokeTracing { def actorCellCreation(cell: ActorCell, system: ActorSystem, ref: ActorRef, props: Props, dispatcher: MessageDispatcher, parent: ActorRef): Unit = {} @After("actorCellCreation(cell, system, ref, props, dispatcher, parent)") - def afterCreation(cell: ActorCellMetrics, system: ActorSystem, ref: ActorRef, props: Props, dispatcher: MessageDispatcher, parent: ActorRef): Unit = { + def afterCreation(cell: ActorCell, system: ActorSystem, ref: ActorRef, props: Props, dispatcher: MessageDispatcher, parent: ActorRef): Unit = { val metricsExtension = Kamon(Metrics)(system) val metricIdentity = ActorMetrics(ref.path.elements.mkString("/")) val cellWithMetrics = cell.asInstanceOf[ActorCellMetrics] @@ -92,11 +91,13 @@ class BehaviourInvokeTracing { } @Pointcut("execution(* akka.actor.ActorCell.handleInvokeFailure(..)) && this(cell)") - def actorInvokeFailure(cell: ActorCellMetrics): Unit = {} + def actorInvokeFailure(cell: ActorCell): Unit = {} @Before("actorInvokeFailure(cell)") - def beforeInvokeFailure(cell: ActorCellMetrics): Unit = { - cell.actorMetricsRecorder.map { + def beforeInvokeFailure(cell: ActorCell): Unit = { + val cellWithMetrics = cell.asInstanceOf[ActorCellMetrics] + + cellWithMetrics.actorMetricsRecorder.map { am ⇒ am.errorCounter.record(1L) } } diff --git a/kamon-core/src/main/scala/kamon/metrics/instruments/CounterRecorder.scala b/kamon-core/src/main/scala/kamon/metrics/instruments/CounterRecorder.scala index 1ab743d2..0fd56105 100644 --- a/kamon-core/src/main/scala/kamon/metrics/instruments/CounterRecorder.scala +++ b/kamon-core/src/main/scala/kamon/metrics/instruments/CounterRecorder.scala @@ -23,7 +23,9 @@ import jsr166e.LongAdder class CounterRecorder extends MetricRecorder { private val counter = new LongAdder - def record(value: Long): Unit = counter.add(value) + def record(value: Long): Unit = { + counter.add(value) + } def collect(): MetricSnapshotLike = { val sum = counter.sumThenReset() -- cgit v1.2.3