From 819406d3ba117b886fedb133959bd7c362a8f726 Mon Sep 17 00:00:00 2001 From: Ivan Topolnjak Date: Mon, 3 Feb 2014 09:22:58 -0300 Subject: initial tests for spray-client instrumentation --- .../can/client/ClientRequestInstrumentation.scala | 44 +++++++++++++++++++--- 1 file changed, 38 insertions(+), 6 deletions(-) (limited to 'kamon-spray/src/main/scala/spray') diff --git a/kamon-spray/src/main/scala/spray/can/client/ClientRequestInstrumentation.scala b/kamon-spray/src/main/scala/spray/can/client/ClientRequestInstrumentation.scala index 868cbaca..4e2a352c 100644 --- a/kamon-spray/src/main/scala/spray/can/client/ClientRequestInstrumentation.scala +++ b/kamon-spray/src/main/scala/spray/can/client/ClientRequestInstrumentation.scala @@ -18,12 +18,15 @@ package spray.can.client import org.aspectj.lang.annotation._ import org.aspectj.lang.ProceedingJoinPoint -import spray.http.{ HttpMessageEnd, HttpRequest } +import spray.http.{ HttpResponse, HttpMessageEnd, HttpRequest } import spray.http.HttpHeaders.Host import kamon.trace.{ TraceRecorder, SegmentCompletionHandleAware, TraceContextAware } import kamon.metrics.TraceMetrics.HttpClientRequest import kamon.Kamon import kamon.spray.Spray +import akka.actor.ActorRef +import scala.concurrent.{ Future, ExecutionContext } +import akka.util.Timeout @Aspect class ClientRequestInstrumentation { @@ -43,13 +46,10 @@ class ClientRequestInstrumentation { // The read to ctx.completionHandle should take care of initializing the aspect timely. if (ctx.segmentCompletionHandle.isEmpty) { TraceRecorder.currentContext.map { traceContext ⇒ - val requestAttributes = Map[String, String]( - "host" -> request.header[Host].map(_.value).getOrElse("unknown"), - "path" -> request.uri.path.toString(), - "method" -> request.method.toString()) - + val requestAttributes = basicRequestAttributes(request) val clientRequestName = Kamon(Spray)(traceContext.system).assignHttpClientRequestName(request) val completionHandle = traceContext.startSegment(HttpClientRequest(clientRequestName, SprayTime), requestAttributes) + ctx.segmentCompletionHandle = Some(completionHandle) } } @@ -82,6 +82,38 @@ class ClientRequestInstrumentation { case None ⇒ pjp.proceed() } } + + @Pointcut("execution(* spray.client.pipelining$.sendReceive(akka.actor.ActorRef, *, *)) && args(transport, ec, timeout)") + def requestLevelApiSendReceive(transport: ActorRef, ec: ExecutionContext, timeout: Timeout): Unit = {} + + @Around("requestLevelApiSendReceive(transport, ec, timeout)") + def aroundRequestLevelApiSendReceive(pjp: ProceedingJoinPoint, transport: ActorRef, ec: ExecutionContext, timeout: Timeout): Any = { + val originalSendReceive = pjp.proceed().asInstanceOf[HttpRequest ⇒ Future[HttpResponse]] + + (request: HttpRequest) ⇒ { + val responseFuture = originalSendReceive.apply(request) + + TraceRecorder.currentContext.map { traceContext ⇒ + val requestAttributes = basicRequestAttributes(request) + val clientRequestName = Kamon(Spray)(traceContext.system).assignHttpClientRequestName(request) + val completionHandle = traceContext.startSegment(HttpClientRequest(clientRequestName, UserTime), requestAttributes) + + responseFuture.onComplete { result ⇒ + completionHandle.finish(Map.empty) + }(ec) + } + + responseFuture + } + + } + + def basicRequestAttributes(request: HttpRequest): Map[String, String] = { + Map[String, String]( + "host" -> request.header[Host].map(_.value).getOrElse("unknown"), + "path" -> request.uri.path.toString(), + "method" -> request.method.toString()) + } } object ClientRequestInstrumentation { -- cgit v1.2.3