From d89c9bdd16c7be729383acf438fcde4cdd863e9c Mon Sep 17 00:00:00 2001 From: Tomasz Bekas Date: Tue, 9 Aug 2016 18:44:04 +0000 Subject: util-eval: Reset reporter between checks Problem When you want to use the util-eval for validating the correctness of a small chunk of code, you have to reset whole state between invocations (flag resetState=true), which is expensive when you already have a bunch of compiled and loaded classes. Without this, if one check fails, all subsequent checks will fail as well, since some errors has been reported previously. Solution Scala compiler API allows for resetting just the reporter, so that compiled and loaded classes can remain for re-usage for next checks. Result Public API remains the same, however the internal API has one new synchronized method resetReporter() which does what is explained in the "Solution" section. Signed-off-by: Ryan O'Neill RB_ID=859878 --- libraries/eval/test/EvalTest.scala | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) (limited to 'libraries/eval/test/EvalTest.scala') diff --git a/libraries/eval/test/EvalTest.scala b/libraries/eval/test/EvalTest.scala index 52913ab..8b986e2 100644 --- a/libraries/eval/test/EvalTest.scala +++ b/libraries/eval/test/EvalTest.scala @@ -205,7 +205,7 @@ class EvalTest extends WordSpec { assert(eval.errors.nonEmpty) } - "reset reporter between invocations" in { + "reset state between invocations" in { val ctx = new Ctx import ctx._ @@ -216,6 +216,22 @@ class EvalTest extends WordSpec { assert(eval[Int]("val d = 3; val e = 2; d + e", true) == 5) assert(eval.errors.isEmpty) } + + "reporter should be reset between checks, but loaded class should remain" in { + val ctx = new Ctx + import ctx._ + + // compile and load compiled class + eval.compile("class A()") + + intercept[Throwable] { + eval.check("new B()") + } + assert(eval.errors.nonEmpty) + + eval.check("new A()") + assert(eval.errors.isEmpty) + } } } } -- cgit v1.2.3