From f66a41379f66638ce9c0ff748f55a47d530a1381 Mon Sep 17 00:00:00 2001 From: Kevin Oliver Date: Wed, 9 Sep 2015 03:22:27 +0000 Subject: util: Cleanup compiler warnings There are a lot of warnings when compiling util, this fixes many of them. RB_ID=739494 --- libraries/eval/test/EvalTest.scala | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) (limited to 'libraries/eval/test/EvalTest.scala') diff --git a/libraries/eval/test/EvalTest.scala b/libraries/eval/test/EvalTest.scala index e53dc47..ad621f0 100644 --- a/libraries/eval/test/EvalTest.scala +++ b/libraries/eval/test/EvalTest.scala @@ -1,18 +1,15 @@ package com.twitter.util +import com.twitter.io.TempFile import java.io.{File, FileWriter} - -import scala.io.Source - import org.junit.runner.RunWith -import org.scalatest.DiagrammedAssertions._ import org.scalatest.WordSpec import org.scalatest.junit.JUnitRunner - -import com.twitter.io.TempFile -import scala.tools.nsc.reporters.{AbstractReporter, Reporter} +import scala.io.Source +import scala.language.reflectiveCalls +import scala.reflect.internal.util.Position import scala.tools.nsc.Settings -import scala.tools.nsc.util.Position +import scala.tools.nsc.reporters.{AbstractReporter, Reporter} @RunWith(classOf[JUnitRunner]) class EvalTest extends WordSpec { @@ -42,7 +39,7 @@ class EvalTest extends WordSpec { val res: String = e(sourceFile) assert(res == "hello") val className = e.fileToClassName(sourceFile) - val processedSource = e.sourceForString(Source.fromFile(sourceFile).getLines.mkString("\n")) + val processedSource = e.sourceForString(Source.fromFile(sourceFile).getLines().mkString("\n")) val fullClassName = "Evaluator__%s_%s.class".format( className, e.uniqueId(processedSource, None)) val targetFileName = f.getAbsolutePath() + File.separator + fullClassName @@ -61,7 +58,7 @@ class EvalTest extends WordSpec { // make sure it created a class file with the expected name val className = e.fileToClassName(sourceFile) - val processedSource = e.sourceForString(Source.fromFile(sourceFile).getLines.mkString("\n")) + val processedSource = e.sourceForString(Source.fromFile(sourceFile).getLines().mkString("\n")) val fullClassName = "Evaluator__%s_%s.class".format( className, e.uniqueId(processedSource, None)) val targetFileName = f.getAbsolutePath() + File.separator + fullClassName @@ -90,7 +87,7 @@ class EvalTest extends WordSpec { // append a newline, altering checksum, verify recompile val writer = new FileWriter(sourceFile) writer.write("//a comment\n2\n") - writer.close + writer.close() val res4: Int = e(sourceFile) assert(res4 == 2) // and make sure it created a new file @@ -180,7 +177,7 @@ class EvalTest extends WordSpec { override val settings: Settings = compilerSettings override def displayPrompt(): Unit = () override def display(pos: Position, msg: String, severity: this.type#Severity): Unit = { - errors = errors :+ (msg, severity.toString) + errors = errors :+ ((msg, severity.toString)) } override def reset() = { super.reset() -- cgit v1.2.3