From 8811b0264591fba3299ace4d537db09613bacb56 Mon Sep 17 00:00:00 2001 From: Staffan Olsson Date: Mon, 8 Jan 2018 13:02:47 +0100 Subject: Revert "Deprecates our own statefulset pod label kafka-broker-id" This reverts commit 096e3bdfba31d2918520011886a6a0d1f1b08c84. --- README.md | 2 -- kafka/10broker-config.yml | 1 - 2 files changed, 3 deletions(-) diff --git a/README.md b/README.md index 4ba9a0c..c349564 100644 --- a/README.md +++ b/README.md @@ -68,8 +68,6 @@ For clusters that enfoce [RBAC](https://kubernetes.io/docs/admin/authorization/r kubectl apply -f rbac-namespace-default/ ``` -For example rack awareness can fail without this, `logs -c init-config` showing `Error from server (Forbidden): pods "kafka-0" is forbidden: User "system:serviceaccount:kafka:default" cannot get pods in the namespace "kafka": Unknown user "system:serviceaccount:kafka:default"`. - ## Tests Tests are based on the [kube-test](https://github.com/Yolean/kube-test) concept. diff --git a/kafka/10broker-config.yml b/kafka/10broker-config.yml index bc1d55d..d11eeaf 100644 --- a/kafka/10broker-config.yml +++ b/kafka/10broker-config.yml @@ -23,7 +23,6 @@ data: sed -i "s/#init#broker.rack=#init#/broker.rack=$ZONE/" /etc/kafka/server.properties fi - # This requires additional RBAC, and won't be needed after https://github.com/kubernetes/kubernetes/pull/55329 kubectl -n $POD_NAMESPACE label pod $POD_NAME kafka-broker-id=$KAFKA_BROKER_ID OUTSIDE_HOST=$(kubectl get node "$NODE_NAME" -o jsonpath='{.status.addresses[?(@.type=="InternalIP")].address}') -- cgit v1.2.3