From f5097f96503dc60f773f68f97beea9e61822d7ee Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Sun, 1 Apr 2018 23:01:42 -0700 Subject: revert #254 to fix bootstrapping https://github.com/lihaoyi/mill/issues/268 --- scalalib/src/mill/scalalib/Dep.scala | 14 ------------ scalalib/src/mill/scalalib/publish/Ivy.scala | 8 ++----- scalalib/src/mill/scalalib/publish/Pom.scala | 28 +++++------------------ scalalib/src/mill/scalalib/publish/settings.scala | 16 ++++--------- 4 files changed, 12 insertions(+), 54 deletions(-) (limited to 'scalalib/src') diff --git a/scalalib/src/mill/scalalib/Dep.scala b/scalalib/src/mill/scalalib/Dep.scala index f67eed03..bd7fce4f 100644 --- a/scalalib/src/mill/scalalib/Dep.scala +++ b/scalalib/src/mill/scalalib/Dep.scala @@ -3,20 +3,6 @@ import mill.util.JsonFormatters._ import upickle.default.{macroRW, ReadWriter => RW} sealed trait Dep { def configure(attributes: coursier.Attributes): Dep - def exclude(exclusions: (String, String)*): Dep = - this match { - case dep : Dep.Java => dep.copy(dep = dep.dep.copy(exclusions = dep.dep.exclusions ++ exclusions)) - case dep : Dep.Scala => dep.copy(dep = dep.dep.copy(exclusions = dep.dep.exclusions ++ exclusions)) - case dep : Dep.Point => dep.copy(dep = dep.dep.copy(exclusions = dep.dep.exclusions ++ exclusions)) - } - def excludeOrg(organizations: String*): Dep = exclude(organizations.map(_ -> "*"): _*) - def excludeName(names: String*): Dep = exclude(names.map("*" -> _): _*) - def withConfiguration(configuration: String): Dep = - this match { - case dep : Dep.Java => dep.copy(dep = dep.dep.copy(configuration = configuration)) - case dep : Dep.Scala => dep.copy(dep = dep.dep.copy(configuration = configuration)) - case dep : Dep.Point => dep.copy(dep = dep.dep.copy(configuration = configuration)) - } } object Dep{ diff --git a/scalalib/src/mill/scalalib/publish/Ivy.scala b/scalalib/src/mill/scalalib/publish/Ivy.scala index 3b271fa8..644e2c53 100644 --- a/scalalib/src/mill/scalalib/publish/Ivy.scala +++ b/scalalib/src/mill/scalalib/publish/Ivy.scala @@ -41,12 +41,8 @@ object Ivy { } private def renderDependency(dep: Dependency) = { - if (dep.exclusions.isEmpty) - default(${dep.configuration.getOrElse("compile")})"} /> - else - default(${dep.configuration.getOrElse("compile")})"}> - {dep.exclusions.map(ex => ).toSeq} - + val scope = scopeToConf(dep.scope) + default(compile)"}> } private def scopeToConf(s: Scope): String = s match { diff --git a/scalalib/src/mill/scalalib/publish/Pom.scala b/scalalib/src/mill/scalalib/publish/Pom.scala index 3c8ba4dc..1a86e7de 100644 --- a/scalalib/src/mill/scalalib/publish/Pom.scala +++ b/scalalib/src/mill/scalalib/publish/Pom.scala @@ -90,28 +90,12 @@ object Pom { case Scope.Test => test case Scope.Runtime => runtime } - if (d.exclusions.isEmpty) - - {d.artifact.group} - {d.artifact.id} - {d.artifact.version} - {scope} - - else - - {d.artifact.group} - {d.artifact.id} - {d.artifact.version} - - {d.exclusions.map(ex => - - {ex._1} - {ex._2} - - )}.toSeq - - {scope} - + + {d.artifact.group} + {d.artifact.id} + {d.artifact.version} + {scope} + } } diff --git a/scalalib/src/mill/scalalib/publish/settings.scala b/scalalib/src/mill/scalalib/publish/settings.scala index 34f7e7ad..1076fb41 100644 --- a/scalalib/src/mill/scalalib/publish/settings.scala +++ b/scalalib/src/mill/scalalib/publish/settings.scala @@ -15,9 +15,7 @@ object Artifact { case Dep.Java(dep, cross) => Dependency( Artifact(dep.module.organization, dep.module.name, dep.version), - Scope.Compile, - if (dep.configuration == "" ) None else Some(dep.configuration), - dep.exclusions.toList + Scope.Compile ) case Dep.Scala(dep, cross) => Dependency( @@ -26,9 +24,7 @@ object Artifact { s"${dep.module.name}_${scalaBin}", dep.version ), - Scope.Compile, - if (dep.configuration == "") None else Some(dep.configuration), - dep.exclusions.toList + Scope.Compile ) case Dep.Point(dep, cross) => Dependency( @@ -37,9 +33,7 @@ object Artifact { s"${dep.module.name}_${scalaFull}", dep.version ), - Scope.Compile, - if (dep.configuration == "") None else Some(dep.configuration), - dep.exclusions.toList + Scope.Compile ) } } @@ -55,9 +49,7 @@ object Scope { case class Dependency( artifact: Artifact, - scope: Scope, - configuration: Option[String] = None, - exclusions: Seq[(String, String)] = Nil + scope: Scope ) case class Developer( -- cgit v1.2.3