diff options
| author | Jie Luo <anandolee@gmail.com> | 2015-04-28 16:26:19 -0700 |
|---|---|---|
| committer | Jie Luo <anandolee@gmail.com> | 2015-04-28 16:26:19 -0700 |
| commit | 8bae6c09bc8c8be808f0acc9b2ad4c9811493060 (patch) | |
| tree | 9819ef25dbe807e4e7f0d6c7dbff7f553b1a8723 /csharp/protos/extest/unittest_issues.proto | |
| parent | 8a3ec53e862cffd310caf434c2c0898782c952f7 (diff) | |
| parent | 32ead755d1f97e414f4a50edb7d9f1ebd9cab562 (diff) | |
| download | protobuf-8bae6c09bc8c8be808f0acc9b2ad4c9811493060.tar.gz protobuf-8bae6c09bc8c8be808f0acc9b2ad4c9811493060.tar.bz2 protobuf-8bae6c09bc8c8be808f0acc9b2ad4c9811493060.zip | |
Merge pull request #1 from google/csharp
Csharp update
Diffstat (limited to 'csharp/protos/extest/unittest_issues.proto')
| -rw-r--r-- | csharp/protos/extest/unittest_issues.proto | 36 |
1 files changed, 20 insertions, 16 deletions
diff --git a/csharp/protos/extest/unittest_issues.proto b/csharp/protos/extest/unittest_issues.proto index cb803791..97249dff 100644 --- a/csharp/protos/extest/unittest_issues.proto +++ b/csharp/protos/extest/unittest_issues.proto @@ -1,10 +1,10 @@ +syntax = "proto2";
+
// These proto descriptors have at one time been reported as an issue or defect.
// They are kept here to replicate the issue, and continue to verify the fix.
-import "google/protobuf/csharp_options.proto";
// Issue: Non-"Google.Protobuffers" namespace will ensure that protobuffer library types are qualified
-option (google.protobuf.csharp_file_options).namespace = "UnitTest.Issues.TestProtos";
-option (google.protobuf.csharp_file_options).umbrella_classname = "UnitTestExtrasIssuesProtoFile";
+option csharp_namespace = "UnitTest.Issues.TestProtos";
package unittest_issues;
option optimize_for = SPEED;
@@ -67,24 +67,28 @@ service TestGenericService { rpc Bar(TestBasicNoFields) returns (TestBasicMessage);
}
*/
-// Issue 13: http://code.google.com/p/protobuf-csharp-port/issues/detail?id=13
+
+// Old issue 13: http://code.google.com/p/protobuf-csharp-port/issues/detail?id=13
+// New issue 309: https://github.com/google/protobuf/issues/309
-message A {
- optional int32 _A = 1;
-}
+// message A {
+// optional int32 _A = 1;
+// }
-message B {
- optional int32 B_ = 1;
-}
+// message B {
+// optional int32 B_ = 1;
+// }
-message AB {
- optional int32 a_b = 1;
-}
+//message AB {
+// optional int32 a_b = 1;
+//}
// Similar issue with numeric names
-message NumberField {
- optional int32 _01 = 1;
-}
+// Java code failed too, so probably best for this to be a restriction.
+// See https://github.com/google/protobuf/issues/308
+// message NumberField {
+// optional int32 _01 = 1;
+// }
// Issue 28: Circular message dependencies result in null defaults for DefaultInstance
|