From b1aac0b4ede7002eefb55dd4cf92c9b18bda1610 Mon Sep 17 00:00:00 2001 From: Jisi Liu Date: Tue, 26 Jul 2016 16:30:35 -0700 Subject: Make protoc-artifacts able to build plugin. --- protoc-artifacts/build-protoc.sh | 29 +++++++++++++++++++++-------- protoc-artifacts/pom.xml | 1 + 2 files changed, 22 insertions(+), 8 deletions(-) diff --git a/protoc-artifacts/build-protoc.sh b/protoc-artifacts/build-protoc.sh index 88e6ae50..e84598f7 100755 --- a/protoc-artifacts/build-protoc.sh +++ b/protoc-artifacts/build-protoc.sh @@ -1,17 +1,30 @@ #!/bin/bash -# Builds protoc executable into target/protoc.exe +# Builds protoc executable into target/protoc.exe; optionally build protoc +# plugins into target/protoc-gen-*.exe # To be run from Maven. -# Usage: build-protoc.sh +# Usage: build-protoc.sh [target] # and are ${os.detected.name} and ${os.detected.arch} from os-maven-plugin +# target can be "protoc" (by default) or protoc-gen-javalite OS=$1 ARCH=$2 +MAKE_TARGET=$3 -if [[ $# < 2 ]]; then +if [[ $# < 3 ]]; then echo "No arguments provided. This script is intended to be run from Maven." exit 1 fi +case $MAKE_TARGET in + protoc-gen-javalite) + ;; + protoc) + ;; + *) + echo "Target ""$TARGET"" invalid." + exit 1 +esac + # Under Cygwin, bash doesn't have these in PATH when called from Maven which # runs in Windows version of Java. export PATH="/bin:/usr/bin:$PATH" @@ -126,7 +139,7 @@ checkDependencies () } ############################################################################ -echo "Building protoc, OS=$OS ARCH=$ARCH" +echo "Building protoc, OS=$OS ARCH=$ARCH TARGET=$TARGET" # Nested double quotes are unintuitive, but it works. cd "$(dirname "$0")" @@ -134,7 +147,6 @@ cd "$(dirname "$0")" WORKING_DIR=$(pwd) CONFIGURE_ARGS="--disable-shared" -MAKE_TARGET="protoc" if [[ "$OS" == windows ]]; then MAKE_TARGET="${MAKE_TARGET}.exe" fi @@ -209,12 +221,13 @@ fi export CXXFLAGS LDFLAGS -TARGET_FILE=target/protoc.exe +TARGET_FILE=target/$MAKE_TARGET.exe cd "$WORKING_DIR"/.. && ./configure $CONFIGURE_ARGS && - cd src && make clean && make $MAKE_TARGET && + cd src && make clean && make $MAKE_TARGET -j4 && cd "$WORKING_DIR" && mkdir -p target && - (cp ../src/protoc $TARGET_FILE || cp ../src/protoc.exe $TARGET_FILE) || + (cp ../src/$MAKE_TARGET $TARGET_FILE || + cp ../src/$MAKE_TARGET.exe $TARGET_FILE) || exit 1 if [[ "$OS" == osx ]]; then diff --git a/protoc-artifacts/pom.xml b/protoc-artifacts/pom.xml index 7661d2f7..840bc60a 100644 --- a/protoc-artifacts/pom.xml +++ b/protoc-artifacts/pom.xml @@ -59,6 +59,7 @@ build-protoc.sh ${os.detected.name} ${os.detected.arch} + protoc -- cgit v1.2.3 From 54feb9ac24b472333f44908939819d675b8e453d Mon Sep 17 00:00:00 2001 From: Jisi Liu Date: Tue, 26 Jul 2016 16:35:28 -0700 Subject: Fix the script comments. --- protoc-artifacts/build-protoc.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/protoc-artifacts/build-protoc.sh b/protoc-artifacts/build-protoc.sh index e84598f7..3eeabecf 100755 --- a/protoc-artifacts/build-protoc.sh +++ b/protoc-artifacts/build-protoc.sh @@ -3,9 +3,9 @@ # Builds protoc executable into target/protoc.exe; optionally build protoc # plugins into target/protoc-gen-*.exe # To be run from Maven. -# Usage: build-protoc.sh [target] +# Usage: build-protoc.sh # and are ${os.detected.name} and ${os.detected.arch} from os-maven-plugin -# target can be "protoc" (by default) or protoc-gen-javalite +# can be "protoc" or protoc-gen-javalite OS=$1 ARCH=$2 MAKE_TARGET=$3 -- cgit v1.2.3 From 7c9c314ca7641672587d28426a05113e952d4e10 Mon Sep 17 00:00:00 2001 From: Jisi Liu Date: Tue, 26 Jul 2016 16:51:30 -0700 Subject: fix comments. --- protoc-artifacts/build-protoc.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/protoc-artifacts/build-protoc.sh b/protoc-artifacts/build-protoc.sh index 3eeabecf..328d6731 100755 --- a/protoc-artifacts/build-protoc.sh +++ b/protoc-artifacts/build-protoc.sh @@ -5,7 +5,7 @@ # To be run from Maven. # Usage: build-protoc.sh # and are ${os.detected.name} and ${os.detected.arch} from os-maven-plugin -# can be "protoc" or protoc-gen-javalite +# can be "protoc" or "protoc-gen-javalite" OS=$1 ARCH=$2 MAKE_TARGET=$3 -- cgit v1.2.3