From 7b7a80eae4f46cca5d3a2781b4412ef769856cdb Mon Sep 17 00:00:00 2001
From: "kenton@google.com"
 <kenton@google.com@630680e5-0e50-0410-840e-4b1c322b438d>
Date: Fri, 8 Jan 2010 03:56:03 +0000
Subject: Tweak doc comments.

---
 java/src/main/java/com/google/protobuf/RpcCallback.java   | 6 ++++++
 java/src/main/java/com/google/protobuf/RpcChannel.java    | 6 ++++++
 java/src/main/java/com/google/protobuf/RpcController.java | 6 ++++++
 java/src/main/java/com/google/protobuf/Service.java       | 6 ++++++
 4 files changed, 24 insertions(+)

(limited to 'java/src')

diff --git a/java/src/main/java/com/google/protobuf/RpcCallback.java b/java/src/main/java/com/google/protobuf/RpcCallback.java
index 841c88a5..1fd35ed3 100644
--- a/java/src/main/java/com/google/protobuf/RpcCallback.java
+++ b/java/src/main/java/com/google/protobuf/RpcCallback.java
@@ -34,6 +34,12 @@ package com.google.protobuf;
  * Interface for an RPC callback, normally called when an RPC completes.
  * {@code ParameterType} is normally the method's response message type.
  *
+ * <p>Starting with version 2.3.0, RPC implementations should not try to build
+ * on this, but should instead provide code generator plugins which generate
+ * code specific to the particular RPC implementation.  This way the generated
+ * code can be more appropriate for the implementation in use and can avoid
+ * unnecessary layers of indirection.
+ *
  * @author kenton@google.com Kenton Varda
  */
 public interface RpcCallback<ParameterType> {
diff --git a/java/src/main/java/com/google/protobuf/RpcChannel.java b/java/src/main/java/com/google/protobuf/RpcChannel.java
index 204ff184..c6ec54fc 100644
--- a/java/src/main/java/com/google/protobuf/RpcChannel.java
+++ b/java/src/main/java/com/google/protobuf/RpcChannel.java
@@ -44,6 +44,12 @@ package com.google.protobuf;
  *   service.myMethod(controller, request, callback);
  * </pre>
  *
+ * <p>Starting with version 2.3.0, RPC implementations should not try to build
+ * on this, but should instead provide code generator plugins which generate
+ * code specific to the particular RPC implementation.  This way the generated
+ * code can be more appropriate for the implementation in use and can avoid
+ * unnecessary layers of indirection.
+ *
  * @author kenton@google.com Kenton Varda
  */
 public interface RpcChannel {
diff --git a/java/src/main/java/com/google/protobuf/RpcController.java b/java/src/main/java/com/google/protobuf/RpcController.java
index a0174221..aaa5446d 100644
--- a/java/src/main/java/com/google/protobuf/RpcController.java
+++ b/java/src/main/java/com/google/protobuf/RpcController.java
@@ -35,6 +35,12 @@ package com.google.protobuf;
  * purpose of the controller is to provide a way to manipulate settings
  * specific to the RPC implementation and to find out about RPC-level errors.
  *
+ * <p>Starting with version 2.3.0, RPC implementations should not try to build
+ * on this, but should instead provide code generator plugins which generate
+ * code specific to the particular RPC implementation.  This way the generated
+ * code can be more appropriate for the implementation in use and can avoid
+ * unnecessary layers of indirection.
+ *
  * <p>The methods provided by the {@code RpcController} interface are intended
  * to be a "least common denominator" set of features which we expect all
  * implementations to support.  Specific implementations may provide more
diff --git a/java/src/main/java/com/google/protobuf/Service.java b/java/src/main/java/com/google/protobuf/Service.java
index 33bcfd31..541585f4 100644
--- a/java/src/main/java/com/google/protobuf/Service.java
+++ b/java/src/main/java/com/google/protobuf/Service.java
@@ -37,6 +37,12 @@ package com.google.protobuf;
  * interface can be used to call the methods of the service without knowing
  * its exact type at compile time (analogous to the Message interface).
  *
+ * <p>Starting with version 2.3.0, RPC implementations should not try to build
+ * on this, but should instead provide code generator plugins which generate
+ * code specific to the particular RPC implementation.  This way the generated
+ * code can be more appropriate for the implementation in use and can avoid
+ * unnecessary layers of indirection.
+ *
  * @author kenton@google.com Kenton Varda
  */
 public interface Service {
-- 
cgit v1.2.3