From a2484208c3291ea522a891114d2821829bd09083 Mon Sep 17 00:00:00 2001 From: Sergio Campamá Date: Fri, 12 Aug 2016 11:44:03 -0700 Subject: Fixes extra whitespace on generated comments. (#1950) Fixes extra whitespace on generated comments. --- .../protobuf/compiler/objectivec/objectivec_helpers.cc | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/google/protobuf/compiler/objectivec/objectivec_helpers.cc b/src/google/protobuf/compiler/objectivec/objectivec_helpers.cc index 28b3f5ae..4a94373a 100644 --- a/src/google/protobuf/compiler/objectivec/objectivec_helpers.cc +++ b/src/google/protobuf/compiler/objectivec/objectivec_helpers.cc @@ -850,14 +850,17 @@ string BuildCommentsString(const SourceLocation& location, string final_comments; string epilogue; + bool add_leading_space = false; + if (prefer_single_line && lines.size() == 1) { prefix = "/** "; suffix = " */\n"; } else { - prefix = " * "; + prefix = "* "; suffix = "\n"; final_comments += "/**\n"; epilogue = " **/\n"; + add_leading_space = true; } for (int i = 0; i < lines.size(); i++) { @@ -868,7 +871,12 @@ string BuildCommentsString(const SourceLocation& location, // Decouple / from * to not have inline comments inside comments. line = StringReplace(line, "/*", "/\\*", true); line = StringReplace(line, "*/", "*\\/", true); - final_comments += prefix + line + suffix; + line = prefix + line; + StripWhitespace(&line); + // If not a one line, need to add the first space before *, as + // StripWhitespace would have removed it. + line = (add_leading_space ? " " : "") + line; + final_comments += line + suffix; } final_comments += epilogue; return final_comments; -- cgit v1.2.3