From df61ab67d3c32e8e996874206299938f5bd1584d Mon Sep 17 00:00:00 2001
From: Adriaan Moors <adriaan.moors@typesafe.com>
Date: Tue, 1 Sep 2015 17:06:33 -0700
Subject: Review feedback from retronym

---
 src/compiler/scala/tools/nsc/typechecker/MethodSynthesis.scala | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/compiler/scala/tools/nsc/typechecker/MethodSynthesis.scala b/src/compiler/scala/tools/nsc/typechecker/MethodSynthesis.scala
index 5fdddf0641..f3632b144d 100644
--- a/src/compiler/scala/tools/nsc/typechecker/MethodSynthesis.scala
+++ b/src/compiler/scala/tools/nsc/typechecker/MethodSynthesis.scala
@@ -338,10 +338,11 @@ trait MethodSynthesis {
         case _                => NoSymbol
       }
 
-      // TODO: when is `derivedSym.isOverloaded`??? is it always an error?
-      private def setterRhs =
+      private def setterRhs = {
+        assert(!derivedSym.isOverloaded, s"Unexpected overloaded setter $derivedSym for $basisSym in $enclClass")
         if (Field.noFieldFor(tree) || derivedSym.isOverloaded) EmptyTree
         else Assign(fieldSelection, Ident(setterParam))
+      }
 
       private def setterDef = DefDef(derivedSym, setterRhs)
       override def derivedTree: Tree = if (setterParam == NoSymbol) EmptyTree else setterDef
-- 
cgit v1.2.3