From 497e073783f25263226447537b574f9f28ef1389 Mon Sep 17 00:00:00 2001
From: paltherr <paltherr@epfl.ch>
Date: Wed, 7 Jan 2004 16:53:21 +0000
Subject: - Fixed lookup(Symbol, ...) to favor concrete o...

- Fixed lookup(Symbol, ...) to favor concrete over deferred members
---
 sources/scalac/symtab/Type.java | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

(limited to 'sources/scalac/symtab')

diff --git a/sources/scalac/symtab/Type.java b/sources/scalac/symtab/Type.java
index b47ec08ab9..220f24d728 100644
--- a/sources/scalac/symtab/Type.java
+++ b/sources/scalac/symtab/Type.java
@@ -871,16 +871,14 @@ public class Type implements Modifiers, Kinds, TypeTags, EntryTags {
      * look up overridden and overriding symbols.
      */
     public Symbol lookup(Symbol sym, Type pre, Relation relation) {
-        // !!! when we find a concrete method, then it is the right
-        // one, but if we find an abstract one, then we need maybe to
-        // search a bit further to see if a concrete one is available
-        // like in lookupNonPrivate. Do we need that ?
         assert !sym.isOverloaded(): Debug.show(sym);
         if (sym.isPrivate() || sym.isStatic() || sym.isInitializer())
             return symbol().isSubClass(sym.owner()) ? sym : Symbol.NONE;
         Type symtype = pre.memberType(sym).derefDef();
         Symbol[] classes = classes();
+        Symbol deferred = null;
         for (int i = 0; i < classes.length; i++) {
+            if (deferred != null && deferred.isSubClass(classes[i])) continue;
             Symbol sym1 = classes[i].members().lookup(sym.name);
             switch (sym1.type()) {
             case NoType:
@@ -888,16 +886,20 @@ public class Type implements Modifiers, Kinds, TypeTags, EntryTags {
                 continue;
             case OverloadedType(Symbol[] alts, _):
                 for (int j = 0; j < alts.length; j++)
-                    if (areRelated(sym, symtype, relation, pre, alts[j],false))
-                        return alts[j];
+                    if (areRelated(sym, symtype, relation, pre,alts[j],false)){
+                        if (!alts[j].isDeferred()) return alts[j];
+                        if (deferred == null) deferred = alts[j];
+                    }
                 continue;
             default:
-                if (areRelated(sym, symtype, relation, pre, sym1, true))
-                    return sym1;
+                if (areRelated(sym, symtype, relation, pre, sym1, true)) {
+                    if (!sym1.isDeferred()) return sym1;
+                    if (deferred == null) deferred = sym1;
+                }
                 continue;
             }
         }
-        return Symbol.NONE;
+        return deferred == null ? Symbol.NONE : deferred;
     }
     //where
     private static boolean areRelated(
-- 
cgit v1.2.3