From 51cd47491e979b10b5d86992dd2e3efd08f7e214 Mon Sep 17 00:00:00 2001 From: Jason Zaugg Date: Sun, 24 Nov 2013 22:25:28 +0100 Subject: Removes Gen*View and Par*View - code that used to be inherited in *View is now inlined - the `view` methods on `ParIteratoa` and `ParSeq` now convert to sequential collections, and are deprecated asking the user to do this explicitly in the future. Should be largely source compatible with 2.10.x, on the assumption that the removed classes, while being public, were internal implementation details. A few tests used now-removed classes to demonstrate compiler crashes. I managed to confirm that after my decoupling, t4365 still exercises the bug: % qbin/scalac test/files/pos/t4365/*.scala warning: there were 2 deprecation warning(s); re-run with -deprecation for details one warning found % scalac-hash 7b4e450 test/files/pos/t4365/*.scala warning: there were 2 deprecation warning(s); re-run with -deprecation for details one warning found % scalac-hash 7b4e450~1 test/files/pos/t4365/*.scala 2<&1 | grep -i wrong error: something is wrong: cannot make sense of type application something is wrong: cannot make sense of type application something is wrong: cannot make sense of type application I didn't manage to do the same for specializes-sym-crash.scala, and instead just made it compile. --- src/library/scala/collection/parallel/ParSeqLike.scala | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) (limited to 'src/library/scala/collection/parallel/ParSeqLike.scala') diff --git a/src/library/scala/collection/parallel/ParSeqLike.scala b/src/library/scala/collection/parallel/ParSeqLike.scala index 33deb84a6f..ca21f24534 100644 --- a/src/library/scala/collection/parallel/ParSeqLike.scala +++ b/src/library/scala/collection/parallel/ParSeqLike.scala @@ -323,16 +323,8 @@ self => override def toSeq = this.asInstanceOf[ParSeq[T]] - @deprecated("views over parallel collections will be removed", "2.11.0") - override def view = new ParSeqView[T, Repr, Sequential] { - protected lazy val underlying = self.repr - protected[this] def viewIdentifier = "" - protected[this] def viewIdString = "" - def length = self.length - def apply(idx: Int) = self(idx) - override def seq = self.seq.view - def splitter = self.splitter - } + @deprecated("use .seq.view", "2.11.0") + override def view = seq.view /* tasks */ -- cgit v1.2.3