From 858615813714aa7c34fe6ce1749dcdd595750a2e Mon Sep 17 00:00:00 2001 From: Miguel Garcia Date: Mon, 8 Jul 2013 22:22:23 +0200 Subject: skipping trips to specializeTypes when not necessary in constructors --- .../scala/tools/nsc/transform/Constructors.scala | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/compiler/scala/tools/nsc/transform/Constructors.scala b/src/compiler/scala/tools/nsc/transform/Constructors.scala index 83cc2ba5c7..a652931f3e 100644 --- a/src/compiler/scala/tools/nsc/transform/Constructors.scala +++ b/src/compiler/scala/tools/nsc/transform/Constructors.scala @@ -442,7 +442,7 @@ abstract class Constructors extends Transform with ast.TreeDSL { // postfix = postfix.tail // } - if (usesSpecializedField && shouldGuard && stats.nonEmpty) { + if (shouldGuard && usesSpecializedField && stats.nonEmpty) { // save them for duplication in the specialized subclass guardedCtorStats(clazz) = stats ctorParams(clazz) = constrInfo.constrParams @@ -522,6 +522,15 @@ abstract class Constructors extends Transform with ast.TreeDSL { } } + /* + * `usesSpecializedField` makes a difference in deciding whether constructor-statements + * should be guarded in a `shouldGuard` class, ie in a class that's the generic super-class of + * one or more specialized sub-classes. + * + * Given that `usesSpecializedField` isn't read for any other purpose than the one described above, + * we skip setting `usesSpecializedField` in case the current class isn't `shouldGuard` to start with. + * That way, trips to a map in `specializeTypes` are saved. + */ var usesSpecializedField: Boolean = false // A transformer for expressions that go into the constructor @@ -564,9 +573,10 @@ abstract class Constructors extends Transform with ast.TreeDSL { // references to parameter accessor field of own class become references to parameters gen.mkAttributedIdent(parameter(tree.symbol)) setPos tree.pos - case Select(_, _) => - if (possiblySpecialized(tree.symbol)) + case Select(_, _) if shouldGuard => // reasoning behind this guard in the docu of `usesSpecializedField` + if (possiblySpecialized(tree.symbol)) { usesSpecializedField = true + } super.transform(tree) case _ => -- cgit v1.2.3