From 94339301cf181103c5eae5918f2410483f3ab8fd Mon Sep 17 00:00:00 2001 From: Geoffrey Washburn Date: Mon, 3 Mar 2008 15:55:10 +0000 Subject: Using java.lang.Boolean.valueOf(...) is more ef... Using java.lang.Boolean.valueOf(...) is more efficent than new java.lang.Boolean(...). --- src/library/scala/Console.scala | 2 +- src/library/scala/mobile/Code.scala | 16 ++++++++-------- src/partest/scala/tools/partest/PartestTask.scala | 2 +- 3 files changed, 10 insertions(+), 10 deletions(-) (limited to 'src') diff --git a/src/library/scala/Console.scala b/src/library/scala/Console.scala index 53f7be09ee..6b2266782b 100644 --- a/src/library/scala/Console.scala +++ b/src/library/scala/Console.scala @@ -317,7 +317,7 @@ object Console { val iter = s.elements while (iter.hasNext) { res(i) = iter.next match { - case x: Boolean => new java.lang.Boolean(x) + case x: Boolean => java.lang.Boolean.valueOf(x) case x: Byte => new java.lang.Byte(x) case x: Short => new java.lang.Short(x) case x: Char => new java.lang.Character(x) diff --git a/src/library/scala/mobile/Code.scala b/src/library/scala/mobile/Code.scala index c9728ea7f0..d58b71403d 100644 --- a/src/library/scala/mobile/Code.scala +++ b/src/library/scala/mobile/Code.scala @@ -160,14 +160,14 @@ class Code(clazz: java.lang.Class[_]) { ////////////////////// private functions /////////////////////// private def boxValue(value: Any) = value match { - case x: Byte => (new java.lang.Byte(x), java.lang.Byte.TYPE) - case x: Boolean => (new java.lang.Boolean(x), java.lang.Boolean.TYPE) - case x: Char => (new java.lang.Character(x), java.lang.Character.TYPE) - case x: Short => (new java.lang.Short(x), java.lang.Short.TYPE) - case x: Int => (new java.lang.Integer(x), java.lang.Integer.TYPE) - case x: Long => (new java.lang.Long(x), java.lang.Long.TYPE) - case x: Float => (new java.lang.Float(x), java.lang.Float.TYPE) - case x: Double => (new java.lang.Double(x), java.lang.Double.TYPE) + case x: Byte => (new java.lang.Byte(x), java.lang.Byte.TYPE) + case x: Boolean => (java.lang.Boolean.valueOf(x), java.lang.Boolean.TYPE) + case x: Char => (new java.lang.Character(x), java.lang.Character.TYPE) + case x: Short => (new java.lang.Short(x), java.lang.Short.TYPE) + case x: Int => (new java.lang.Integer(x), java.lang.Integer.TYPE) + case x: Long => (new java.lang.Long(x), java.lang.Long.TYPE) + case x: Float => (new java.lang.Float(x), java.lang.Float.TYPE) + case x: Double => (new java.lang.Double(x), java.lang.Double.TYPE) case _ => val x = value.asInstanceOf[JObject] (x, x.getClass()) diff --git a/src/partest/scala/tools/partest/PartestTask.scala b/src/partest/scala/tools/partest/PartestTask.scala index 75c2472df3..6a6a0662c5 100644 --- a/src/partest/scala/tools/partest/PartestTask.scala +++ b/src/partest/scala/tools/partest/PartestTask.scala @@ -116,7 +116,7 @@ class PartestTask extends Task { def setFileManagerBooleanProperty(name: String, value: Boolean) = { val setMethod = antFileManager.getClass.getMethod(name+"_$eq", Array(classOf[Boolean])) - setMethod.invoke(antFileManager, Array(new java.lang.Boolean(value))) + setMethod.invoke(antFileManager, Array(java.lang.Boolean.valueOf(value))) } def setFileManagerStringProperty(name: String, value: String) = { -- cgit v1.2.3