From cb754b1a5698e231c84d94ee18508c21480c2335 Mon Sep 17 00:00:00 2001 From: Paul Phillips Date: Mon, 19 Oct 2009 22:18:21 +0000 Subject: Relaxing a check for ticket #2486, plus test case. proposing this as the long-term fix (unless by some miracle it is the right fix, in which case good for me.) --- .../scala/tools/nsc/typechecker/Infer.scala | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) (limited to 'src') diff --git a/src/compiler/scala/tools/nsc/typechecker/Infer.scala b/src/compiler/scala/tools/nsc/typechecker/Infer.scala index 6c3b6af081..4a9399bf99 100644 --- a/src/compiler/scala/tools/nsc/typechecker/Infer.scala +++ b/src/compiler/scala/tools/nsc/typechecker/Infer.scala @@ -1419,11 +1419,23 @@ trait Infer { val ptvars = ptparams map freshVar val pt1 = pt.instantiateTypeParams(ptparams, ptvars) if (!(isPopulated(tp, pt1) && isInstantiatable(tvars ::: ptvars))) { - //println(tpparams) - //println(tvars map instBounds) - //println(ptvars map instBounds) - error(pos, "pattern type is incompatible with expected type"+foundReqMsg(pattp, pt)) - return pattp + // In ticket #2486 we have this example of code which would fail + // here without a change: + // + // class A[T] + // class B extends A[Int] + // class C[T] extends A[T] { def f(t: A[T]) = t match { case x: B => () } } + // + // This reports error: pattern type is incompatible with expected type; + // found : B + // required: A[T] + // + // I am not sure what is the ideal fix, but for the moment I am intercepting + // it at the last minute and applying a looser check before failing. + if (!isPlausiblyCompatible(pattp, pt)) { + error(pos, "pattern type is incompatible with expected type"+foundReqMsg(pattp, pt)) + return pattp + } } ptvars foreach instantiateTypeVar } -- cgit v1.2.3