aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorReynold Xin <rxin@databricks.com>2016-11-04 23:34:29 -0700
committerReynold Xin <rxin@databricks.com>2016-11-04 23:34:29 -0700
commit0f7c9e84e0d00813bf56712097677add5657f19f (patch)
tree29ca94f215b1d0c9a6201309f180c578a719edbd
parent0e3312ee72c44f4c9acafbd80d0c8a14f3aff875 (diff)
downloadspark-0f7c9e84e0d00813bf56712097677add5657f19f.tar.gz
spark-0f7c9e84e0d00813bf56712097677add5657f19f.tar.bz2
spark-0f7c9e84e0d00813bf56712097677add5657f19f.zip
[SPARK-18189] [SQL] [Followup] Move test from ReplSuite to prevent java.lang.ClassCircularityError
closes #15774
-rw-r--r--repl/scala-2.11/src/test/scala/org/apache/spark/repl/ReplSuite.scala17
-rw-r--r--sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala12
2 files changed, 12 insertions, 17 deletions
diff --git a/repl/scala-2.11/src/test/scala/org/apache/spark/repl/ReplSuite.scala b/repl/scala-2.11/src/test/scala/org/apache/spark/repl/ReplSuite.scala
index 96d2dfc265..9262e938c2 100644
--- a/repl/scala-2.11/src/test/scala/org/apache/spark/repl/ReplSuite.scala
+++ b/repl/scala-2.11/src/test/scala/org/apache/spark/repl/ReplSuite.scala
@@ -473,21 +473,4 @@ class ReplSuite extends SparkFunSuite {
assertDoesNotContain("AssertionError", output)
assertDoesNotContain("Exception", output)
}
-
- test("SPARK-18189: Fix serialization issue in KeyValueGroupedDataset") {
- val resultValue = 12345
- val output = runInterpreter("local",
- s"""
- |val keyValueGrouped = Seq((1, 2), (3, 4)).toDS().groupByKey(_._1)
- |val mapGroups = keyValueGrouped.mapGroups((k, v) => (k, 1))
- |val broadcasted = sc.broadcast($resultValue)
- |
- |// Using broadcast triggers serialization issue in KeyValueGroupedDataset
- |val dataset = mapGroups.map(_ => broadcasted.value)
- |dataset.collect()
- """.stripMargin)
- assertDoesNotContain("error:", output)
- assertDoesNotContain("Exception", output)
- assertContains(s": Array[Int] = Array($resultValue, $resultValue)", output)
- }
}
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
index 55f0487805..6fa7b04877 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
@@ -923,6 +923,18 @@ class DatasetSuite extends QueryTest with SharedSQLContext {
.groupByKey(_.a).flatMapGroups { case (x, iter) => List[Int]() })
}
+ test("SPARK-18189: Fix serialization issue in KeyValueGroupedDataset") {
+ val resultValue = 12345
+ val keyValueGrouped = Seq((1, 2), (3, 4)).toDS().groupByKey(_._1)
+ val mapGroups = keyValueGrouped.mapGroups((k, v) => (k, 1))
+ val broadcasted = spark.sparkContext.broadcast(resultValue)
+
+ // Using broadcast triggers serialization issue in KeyValueGroupedDataset
+ val dataset = mapGroups.map(_ => broadcasted.value)
+
+ assert(dataset.collect() sameElements Array(resultValue, resultValue))
+ }
+
Seq(true, false).foreach { eager =>
def testCheckpointing(testName: String)(f: => Unit): Unit = {
test(s"Dataset.checkpoint() - $testName (eager = $eager)") {