From 9fba9c8004d2b97549e5456fa7918965bec27336 Mon Sep 17 00:00:00 2001 From: Yuhao Yang Date: Thu, 10 Dec 2015 10:15:50 -0800 Subject: [SPARK-11602][MLLIB] Refine visibility for 1.6 scala API audit jira: https://issues.apache.org/jira/browse/SPARK-11602 Made a pass on the API change of 1.6. Open the PR for efficient discussion. Author: Yuhao Yang Closes #9939 from hhbyyh/auditScala. --- mllib/src/main/scala/org/apache/spark/ml/feature/package-info.java | 2 +- .../main/scala/org/apache/spark/ml/regression/LinearRegression.scala | 2 +- .../scala/org/apache/spark/mllib/clustering/BisectingKMeans.scala | 2 +- .../org/apache/spark/mllib/clustering/BisectingKMeansModel.scala | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/mllib/src/main/scala/org/apache/spark/ml/feature/package-info.java b/mllib/src/main/scala/org/apache/spark/ml/feature/package-info.java index c22d2e0cd2..7a35f2d448 100644 --- a/mllib/src/main/scala/org/apache/spark/ml/feature/package-info.java +++ b/mllib/src/main/scala/org/apache/spark/ml/feature/package-info.java @@ -23,7 +23,7 @@ * features into more suitable forms for model fitting. * Most feature transformers are implemented as {@link org.apache.spark.ml.Transformer}s, which * transforms one {@link org.apache.spark.sql.DataFrame} into another, e.g., - * {@link org.apache.spark.feature.HashingTF}. + * {@link org.apache.spark.ml.feature.HashingTF}. * Some feature transformers are implemented as {@link org.apache.spark.ml.Estimator}}s, because the * transformation requires some aggregated information of the dataset, e.g., document * frequencies in {@link org.apache.spark.ml.feature.IDF}. diff --git a/mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala b/mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala index 1db91666f2..5e5850963e 100644 --- a/mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala +++ b/mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala @@ -529,7 +529,7 @@ class LinearRegressionSummary private[regression] ( val predictionCol: String, val labelCol: String, val model: LinearRegressionModel, - val diagInvAtWA: Array[Double]) extends Serializable { + private val diagInvAtWA: Array[Double]) extends Serializable { @transient private val metrics = new RegressionMetrics( predictions diff --git a/mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeans.scala b/mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeans.scala index 82adfa6ffd..54bf5102cc 100644 --- a/mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeans.scala +++ b/mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeans.scala @@ -407,7 +407,7 @@ private object BisectingKMeans extends Serializable { */ @Since("1.6.0") @Experimental -class ClusteringTreeNode private[clustering] ( +private[clustering] class ClusteringTreeNode private[clustering] ( val index: Int, val size: Long, private val centerWithNorm: VectorWithNorm, diff --git a/mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeansModel.scala b/mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeansModel.scala index f942e5613f..9ccf96b939 100644 --- a/mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeansModel.scala +++ b/mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeansModel.scala @@ -32,8 +32,8 @@ import org.apache.spark.rdd.RDD */ @Since("1.6.0") @Experimental -class BisectingKMeansModel @Since("1.6.0") ( - @Since("1.6.0") val root: ClusteringTreeNode +class BisectingKMeansModel private[clustering] ( + private[clustering] val root: ClusteringTreeNode ) extends Serializable with Logging { /** -- cgit v1.2.3