From adaaffa34ef0ef6a7baa5c1fea848cf5bc3987a2 Mon Sep 17 00:00:00 2001 From: Tejas Patil Date: Thu, 1 Sep 2016 16:47:37 +0800 Subject: [SPARK-17271][SQL] Remove redundant `semanticEquals()` from `SortOrder` ## What changes were proposed in this pull request? Removing `semanticEquals()` from `SortOrder` because it can use the `semanticEquals()` provided by its parent class (`Expression`). This was as per suggestion by cloud-fan at https://github.com/apache/spark/pull/14841/files/7192418b3a26a14642fc04fc92bf496a954ffa5d#r77106801 ## How was this patch tested? Ran the test added in https://github.com/apache/spark/pull/14841 Author: Tejas Patil Closes #14910 from tejasapatil/SPARK-17271_remove_semantic_ordering. --- .../scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala | 3 --- 1 file changed, 3 deletions(-) diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala index f498f35792..de779ed370 100644 --- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala +++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SortOrder.scala @@ -61,9 +61,6 @@ case class SortOrder(child: Expression, direction: SortDirection) override def sql: String = child.sql + " " + direction.sql def isAscending: Boolean = direction == Ascending - - def semanticEquals(other: SortOrder): Boolean = - (direction == other.direction) && child.semanticEquals(other.child) } /** -- cgit v1.2.3