From c6ceaeae50c7b5d69bb9897af32f537bfbde152d Mon Sep 17 00:00:00 2001 From: Nick Pentreath Date: Fri, 4 Oct 2013 13:52:53 +0200 Subject: Style fix using 'if' rather than 'match' on boolean --- .../apache/spark/mllib/recommendation/ALS.scala | 27 +++++++++++----------- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala b/mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala index 5935d2754d..36853acab5 100644 --- a/mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala +++ b/mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala @@ -207,20 +207,19 @@ class ALS private (var numBlocks: Int, var rank: Int, var iterations: Int, var l * @return Option[YtY] - whose value is only used in the implicit preference model */ def computeYtY(factors: RDD[(Int, Array[Array[Double]])]) = { - implicitPrefs match { - case true => { - Option( - factors.flatMapValues{ case factorArray => - factorArray.map{ vector => - val x = new DoubleMatrix(vector) - x.mmul(x.transpose()) - } - }.reduceByKeyLocally((a, b) => a.addi(b)) - .values - .reduce((a, b) => a.addi(b)) - ) - } - case false => None + if (implicitPrefs) { + Option( + factors.flatMapValues{ case factorArray => + factorArray.map{ vector => + val x = new DoubleMatrix(vector) + x.mmul(x.transpose()) + } + }.reduceByKeyLocally((a, b) => a.addi(b)) + .values + .reduce((a, b) => a.addi(b)) + ) + } else { + None } } -- cgit v1.2.3