From de6e633420aba1fe5d806a2725a95e610699ae7d Mon Sep 17 00:00:00 2001
From: Azeem Jiva <azeemj@gmail.com>
Date: Tue, 26 Apr 2016 11:49:04 +0100
Subject: [SPARK-14756][CORE] Use parseLong instead of valueOf

## What changes were proposed in this pull request?

Use Long.parseLong which returns a primative.
Use a series of appends() reduces the creation of an extra StringBuilder type

## How was this patch tested?

Unit tests

Author: Azeem Jiva <azeemj@gmail.com>

Closes #12520 from javawithjiva/minor.
---
 .../main/java/org/apache/spark/unsafe/types/CalendarInterval.java | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

(limited to 'common/unsafe')

diff --git a/common/unsafe/src/main/java/org/apache/spark/unsafe/types/CalendarInterval.java b/common/unsafe/src/main/java/org/apache/spark/unsafe/types/CalendarInterval.java
index 62edf6c64b..518ed6470a 100644
--- a/common/unsafe/src/main/java/org/apache/spark/unsafe/types/CalendarInterval.java
+++ b/common/unsafe/src/main/java/org/apache/spark/unsafe/types/CalendarInterval.java
@@ -62,7 +62,7 @@ public final class CalendarInterval implements Serializable {
     if (s == null) {
       return 0;
     } else {
-      return Long.valueOf(s);
+      return Long.parseLong(s);
     }
   }
 
@@ -91,7 +91,7 @@ public final class CalendarInterval implements Serializable {
       String s, long minValue, long maxValue) throws IllegalArgumentException {
     long result = 0;
     if (s != null) {
-      result = Long.valueOf(s);
+      result = Long.parseLong(s);
       if (result < minValue || result > maxValue) {
         throw new IllegalArgumentException(String.format("%s %d outside range [%d, %d]",
           fieldName, result, minValue, maxValue));
@@ -218,7 +218,7 @@ public final class CalendarInterval implements Serializable {
           result = new CalendarInterval(0, millisecond * MICROS_PER_MILLI);
 
         } else if (unit.equals("microsecond")) {
-          long micros = Long.valueOf(m.group(1));
+          long micros = Long.parseLong(m.group(1));
           result = new CalendarInterval(0, micros);
         }
       } catch (Exception e) {
@@ -318,7 +318,7 @@ public final class CalendarInterval implements Serializable {
 
   private void appendUnit(StringBuilder sb, long value, String unit) {
     if (value != 0) {
-      sb.append(" " + value + " " + unit + "s");
+      sb.append(' ').append(value).append(' ').append(unit).append('s');
     }
   }
 }
-- 
cgit v1.2.3