From f405de87c878c49b17acb2c874be1084465384e9 Mon Sep 17 00:00:00 2001 From: Dongjoon Hyun Date: Wed, 27 Apr 2016 20:56:23 +0100 Subject: [SPARK-14867][BUILD] Remove `--force` option in `build/mvn` ## What changes were proposed in this pull request? Currently, `build/mvn` provides a convenient option, `--force`, in order to use the recommended version of maven without changing PATH environment variable. However, there were two problems. - `dev/lint-java` does not use the newly installed maven. ```bash $ ./build/mvn --force clean $ ./dev/lint-java Using `mvn` from path: /usr/local/bin/mvn ``` - It's not easy to type `--force` option always. If '--force' option is used once, we had better prefer the installed maven recommended by Spark. This PR makes `build/mvn` check the existence of maven installed by `--force` option first. According to the comments, this PR aims to the followings: - Detect the maven version from `pom.xml`. - Install maven if there is no or old maven. - Remove `--force` option. ## How was this patch tested? Manual. ```bash $ ./build/mvn --force clean $ ./dev/lint-java Using `mvn` from path: /Users/dongjoon/spark/build/apache-maven-3.3.9/bin/mvn ... $ rm -rf ./build/apache-maven-3.3.9/ $ ./dev/lint-java Using `mvn` from path: /usr/local/bin/mvn ``` Author: Dongjoon Hyun Closes #12631 from dongjoon-hyun/SPARK-14867. --- dev/test-dependencies.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'dev/test-dependencies.sh') diff --git a/dev/test-dependencies.sh b/dev/test-dependencies.sh index 924b55287c..5ea643ee48 100755 --- a/dev/test-dependencies.sh +++ b/dev/test-dependencies.sh @@ -30,7 +30,7 @@ export LC_ALL=C # NOTE: These should match those in the release publishing script HADOOP2_MODULE_PROFILES="-Phive-thriftserver -Pyarn -Phive" -MVN="build/mvn --force" +MVN="build/mvn" HADOOP_PROFILES=( hadoop-2.2 hadoop-2.3 -- cgit v1.2.3