From d34d6503786bbe429c10ddb1879519cc9bd709b6 Mon Sep 17 00:00:00 2001 From: Dongjoon Hyun Date: Sun, 24 Apr 2016 20:40:03 -0700 Subject: [SPARK-14868][BUILD] Enable NewLineAtEofChecker in checkstyle and fix lint-java errors ## What changes were proposed in this pull request? Spark uses `NewLineAtEofChecker` rule in Scala by ScalaStyle. And, most Java code also comply with the rule. This PR aims to enforce the same rule `NewlineAtEndOfFile` by CheckStyle explicitly. Also, this fixes lint-java errors since SPARK-14465. The followings are the items. - Adds a new line at the end of the files (19 files) - Fixes 25 lint-java errors (12 RedundantModifier, 6 **ArrayTypeStyle**, 2 LineLength, 2 UnusedImports, 2 RegexpSingleline, 1 ModifierOrder) ## How was this patch tested? After the Jenkins test succeeds, `dev/lint-java` should pass. (Currently, Jenkins dose not run lint-java.) ```bash $ dev/lint-java Using `mvn` from path: /usr/local/bin/mvn Checkstyle checks passed. ``` Author: Dongjoon Hyun Closes #12632 from dongjoon-hyun/SPARK-14868. --- .../src/main/scala/org/apache/spark/streaming/flume/package-info.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'external/flume') diff --git a/external/flume/src/main/scala/org/apache/spark/streaming/flume/package-info.java b/external/flume/src/main/scala/org/apache/spark/streaming/flume/package-info.java index d31aa5f5c0..4a5da226ad 100644 --- a/external/flume/src/main/scala/org/apache/spark/streaming/flume/package-info.java +++ b/external/flume/src/main/scala/org/apache/spark/streaming/flume/package-info.java @@ -18,4 +18,4 @@ /** * Spark streaming receiver for Flume. */ -package org.apache.spark.streaming.flume; \ No newline at end of file +package org.apache.spark.streaming.flume; -- cgit v1.2.3