From c6023bee60cee06b3dd31bb8253da6e07862c13d Mon Sep 17 00:00:00 2001 From: Ankur Dave Date: Mon, 13 Jan 2014 21:00:25 -0800 Subject: Fix infinite loop in GraphGenerators.generateRandomEdges The loop occurred when numEdges < numVertices. This commit fixes it by allowing generateRandomEdges to generate a multigraph. --- .../scala/org/apache/spark/graphx/util/GraphGenerators.scala | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) (limited to 'graphx') diff --git a/graphx/src/main/scala/org/apache/spark/graphx/util/GraphGenerators.scala b/graphx/src/main/scala/org/apache/spark/graphx/util/GraphGenerators.scala index dbea233c34..57422ce3f1 100644 --- a/graphx/src/main/scala/org/apache/spark/graphx/util/GraphGenerators.scala +++ b/graphx/src/main/scala/org/apache/spark/graphx/util/GraphGenerators.scala @@ -44,14 +44,7 @@ object GraphGenerators { def generateRandomEdges(src: Int, numEdges: Int, maxVertexID: Int): Array[Edge[Int]] = { val rand = new Random() - var dsts: Set[Int] = Set() - while (dsts.size < numEdges) { - val nextDst = rand.nextInt(maxVertexID) - if (nextDst != src) { - dsts += nextDst - } - } - dsts.map(dst => Edge[Int](src, dst, 1)).toArray + Array.fill(maxVertexID) { Edge[Int](src, rand.nextInt(maxVertexID), 1) } } /** -- cgit v1.2.3