From e388bd54499cb4c26a0e14efd47af0c684ca250f Mon Sep 17 00:00:00 2001 From: Yucai Yu Date: Thu, 1 Sep 2016 14:13:38 -0700 Subject: [SPARK-16732][SQL] Remove unused codes in subexpressionEliminationForWholeStageCodegen ## What changes were proposed in this pull request? Some codes in subexpressionEliminationForWholeStageCodegen are never used actually. Remove them using this PR. ## How was this patch tested? Local unit tests. Author: Yucai Yu Closes #14366 from yucai/subExpr_unused_codes. --- .../apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala | 4 ---- 1 file changed, 4 deletions(-) (limited to 'sql/catalyst') diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala index 4bd9ee03f9..28064a5cfa 100644 --- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala +++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala @@ -662,10 +662,6 @@ class CodegenContext { val commonExprs = equivalentExpressions.getAllEquivalentExprs.filter(_.size > 1) val codes = commonExprs.map { e => val expr = e.head - val fnName = freshName("evalExpr") - val isNull = s"${fnName}IsNull" - val value = s"${fnName}Value" - // Generate the code for this expression tree. val code = expr.genCode(this) val state = SubExprEliminationState(code.isNull, code.value) -- cgit v1.2.3