From 6a9423b428c78e4c2ea295544df50f5b1f0cd49d Mon Sep 17 00:00:00 2001 From: Thomas Gubler Date: Sun, 29 Dec 2013 16:35:52 +0100 Subject: fw att ctrl: remove renamed parameters --- src/lib/ecl/attitude_fw/ecl_pitch_controller.cpp | 1 - src/lib/ecl/attitude_fw/ecl_pitch_controller.h | 4 ---- src/lib/ecl/attitude_fw/ecl_roll_controller.cpp | 1 - src/lib/ecl/attitude_fw/ecl_roll_controller.h | 5 ----- src/lib/ecl/attitude_fw/ecl_yaw_controller.cpp | 1 - src/lib/ecl/attitude_fw/ecl_yaw_controller.h | 5 ----- 6 files changed, 17 deletions(-) (limited to 'src/lib') diff --git a/src/lib/ecl/attitude_fw/ecl_pitch_controller.cpp b/src/lib/ecl/attitude_fw/ecl_pitch_controller.cpp index d7dbbebd4..882fac02b 100644 --- a/src/lib/ecl/attitude_fw/ecl_pitch_controller.cpp +++ b/src/lib/ecl/attitude_fw/ecl_pitch_controller.cpp @@ -52,7 +52,6 @@ ECL_PitchController::ECL_PitchController() : _tc(0.1f), _k_p(0.0f), _k_i(0.0f), - _k_d(0.0f), _k_ff(0.0f), _integrator_max(0.0f), _max_rate_pos(0.0f), diff --git a/src/lib/ecl/attitude_fw/ecl_pitch_controller.h b/src/lib/ecl/attitude_fw/ecl_pitch_controller.h index 2ca0490fd..30a82a86a 100644 --- a/src/lib/ecl/attitude_fw/ecl_pitch_controller.h +++ b/src/lib/ecl/attitude_fw/ecl_pitch_controller.h @@ -77,9 +77,6 @@ public: void set_k_i(float k_i) { _k_i = k_i; } - void set_k_d(float k_d) { - _k_d = k_d; - } void set_k_ff(float k_ff) { _k_ff = k_ff; @@ -119,7 +116,6 @@ private: float _tc; float _k_p; float _k_i; - float _k_d; float _k_ff; float _integrator_max; float _max_rate_pos; diff --git a/src/lib/ecl/attitude_fw/ecl_roll_controller.cpp b/src/lib/ecl/attitude_fw/ecl_roll_controller.cpp index bd6c9da71..9e7d35f68 100644 --- a/src/lib/ecl/attitude_fw/ecl_roll_controller.cpp +++ b/src/lib/ecl/attitude_fw/ecl_roll_controller.cpp @@ -52,7 +52,6 @@ ECL_RollController::ECL_RollController() : _tc(0.1f), _k_p(0.0f), _k_i(0.0f), - _k_d(0.0f), _k_ff(0.0f), _integrator_max(0.0f), _max_rate(0.0f), diff --git a/src/lib/ecl/attitude_fw/ecl_roll_controller.h b/src/lib/ecl/attitude_fw/ecl_roll_controller.h index efc7b8944..92c64b95f 100644 --- a/src/lib/ecl/attitude_fw/ecl_roll_controller.h +++ b/src/lib/ecl/attitude_fw/ecl_roll_controller.h @@ -80,10 +80,6 @@ public: _k_i = k_i; } - void set_k_d(float k_d) { - _k_d = k_d; - } - void set_k_ff(float k_ff) { _k_ff = k_ff; } @@ -113,7 +109,6 @@ private: float _tc; float _k_p; float _k_i; - float _k_d; float _k_ff; float _integrator_max; float _max_rate; diff --git a/src/lib/ecl/attitude_fw/ecl_yaw_controller.cpp b/src/lib/ecl/attitude_fw/ecl_yaw_controller.cpp index 7c366aaf2..15e2b0f71 100644 --- a/src/lib/ecl/attitude_fw/ecl_yaw_controller.cpp +++ b/src/lib/ecl/attitude_fw/ecl_yaw_controller.cpp @@ -50,7 +50,6 @@ ECL_YawController::ECL_YawController() : _last_run(0), _k_p(0.0f), _k_i(0.0f), - _k_d(0.0f), _k_ff(0.0f), _integrator_max(0.0f), _max_rate(0.0f), diff --git a/src/lib/ecl/attitude_fw/ecl_yaw_controller.h b/src/lib/ecl/attitude_fw/ecl_yaw_controller.h index f15645fcf..f61698c36 100644 --- a/src/lib/ecl/attitude_fw/ecl_yaw_controller.h +++ b/src/lib/ecl/attitude_fw/ecl_yaw_controller.h @@ -75,10 +75,6 @@ public: _k_i = k_i; } - void set_k_d(float k_d) { - _k_d = k_d; - } - void set_k_ff(float k_ff) { _k_ff = k_ff; } @@ -116,7 +112,6 @@ private: uint64_t _last_run; float _k_p; float _k_i; - float _k_d; float _k_ff; float _integrator_max; float _max_rate; -- cgit v1.2.3 From 95bdc1a9bd364ce95abe06b097579cc8a9162e33 Mon Sep 17 00:00:00 2001 From: Thomas Gubler Date: Sun, 29 Dec 2013 16:42:31 +0100 Subject: fw att ctrl: removed unused parameter --- src/lib/ecl/attitude_fw/ecl_pitch_controller.cpp | 1 + src/lib/ecl/attitude_fw/ecl_yaw_controller.cpp | 1 - src/lib/ecl/attitude_fw/ecl_yaw_controller.h | 4 ---- src/modules/fw_att_control/fw_att_control_main.cpp | 3 --- src/modules/fw_att_control/fw_att_control_params.c | 4 +--- 5 files changed, 2 insertions(+), 11 deletions(-) (limited to 'src/lib') diff --git a/src/lib/ecl/attitude_fw/ecl_pitch_controller.cpp b/src/lib/ecl/attitude_fw/ecl_pitch_controller.cpp index 882fac02b..b66d1dba5 100644 --- a/src/lib/ecl/attitude_fw/ecl_pitch_controller.cpp +++ b/src/lib/ecl/attitude_fw/ecl_pitch_controller.cpp @@ -90,6 +90,7 @@ float ECL_PitchController::control_attitude(float pitch_setpoint, float roll, fl } /* calculate the offset in the rate resulting from rolling */ + //xxx needs explanation and conversion to body angular rates or should be removed float turn_offset = fabsf((CONSTANTS_ONE_G / airspeed) * tanf(roll) * sinf(roll)) * _roll_ff; if (inverted) diff --git a/src/lib/ecl/attitude_fw/ecl_yaw_controller.cpp b/src/lib/ecl/attitude_fw/ecl_yaw_controller.cpp index 15e2b0f71..5e2200727 100644 --- a/src/lib/ecl/attitude_fw/ecl_yaw_controller.cpp +++ b/src/lib/ecl/attitude_fw/ecl_yaw_controller.cpp @@ -53,7 +53,6 @@ ECL_YawController::ECL_YawController() : _k_ff(0.0f), _integrator_max(0.0f), _max_rate(0.0f), - _roll_ff(0.0f), _last_output(0.0f), _integrator(0.0f), _rate_error(0.0f), diff --git a/src/lib/ecl/attitude_fw/ecl_yaw_controller.h b/src/lib/ecl/attitude_fw/ecl_yaw_controller.h index f61698c36..03f3202d0 100644 --- a/src/lib/ecl/attitude_fw/ecl_yaw_controller.h +++ b/src/lib/ecl/attitude_fw/ecl_yaw_controller.h @@ -87,10 +87,6 @@ public: _max_rate = max_rate; } - void set_k_roll_ff(float roll_ff) { - _roll_ff = roll_ff; - } - void set_coordinated_min_speed(float coordinated_min_speed) { _coordinated_min_speed = coordinated_min_speed; } diff --git a/src/modules/fw_att_control/fw_att_control_main.cpp b/src/modules/fw_att_control/fw_att_control_main.cpp index 9d8b420ac..df9d325b3 100644 --- a/src/modules/fw_att_control/fw_att_control_main.cpp +++ b/src/modules/fw_att_control/fw_att_control_main.cpp @@ -326,7 +326,6 @@ FixedwingAttitudeControl::FixedwingAttitudeControl() : _parameter_handles.y_p = param_find("FW_YR_P"); _parameter_handles.y_i = param_find("FW_YR_I"); _parameter_handles.y_ff = param_find("FW_YR_FF"); - _parameter_handles.y_roll_feedforward = param_find("FW_Y_ROLLFF"); _parameter_handles.y_integrator_max = param_find("FW_YR_IMAX"); _parameter_handles.y_rmax = param_find("FW_Y_RMAX"); @@ -388,7 +387,6 @@ FixedwingAttitudeControl::parameters_update() param_get(_parameter_handles.y_p, &(_parameters.y_p)); param_get(_parameter_handles.y_i, &(_parameters.y_i)); param_get(_parameter_handles.y_ff, &(_parameters.y_ff)); - param_get(_parameter_handles.y_roll_feedforward, &(_parameters.y_roll_feedforward)); param_get(_parameter_handles.y_integrator_max, &(_parameters.y_integrator_max)); param_get(_parameter_handles.y_coordinated_min_speed, &(_parameters.y_coordinated_min_speed)); param_get(_parameter_handles.y_rmax, &(_parameters.y_rmax)); @@ -419,7 +417,6 @@ FixedwingAttitudeControl::parameters_update() _yaw_ctrl.set_k_p(_parameters.y_p); _yaw_ctrl.set_k_i(_parameters.y_i); _yaw_ctrl.set_k_ff(_parameters.y_ff); - _yaw_ctrl.set_k_roll_ff(_parameters.y_roll_feedforward); _yaw_ctrl.set_integrator_max(_parameters.y_integrator_max); _yaw_ctrl.set_coordinated_min_speed(_parameters.y_coordinated_min_speed); _yaw_ctrl.set_max_rate(math::radians(_parameters.y_rmax)); diff --git a/src/modules/fw_att_control/fw_att_control_params.c b/src/modules/fw_att_control/fw_att_control_params.c index 16227b62f..1c615094c 100644 --- a/src/modules/fw_att_control/fw_att_control_params.c +++ b/src/modules/fw_att_control/fw_att_control_params.c @@ -86,7 +86,7 @@ PARAM_DEFINE_FLOAT(FW_PR_IMAX, 0.2f); // @Range 0.5 2.0 // @Increment 0.05 // @User User -PARAM_DEFINE_FLOAT(FW_P_ROLLFF, 0.0f); +PARAM_DEFINE_FLOAT(FW_P_ROLLFF, 0.0f); //xxx: set to 0 as default, see comment in ECL_PitchController::control_attitude (float turn_offset = ...) // @DisplayName Roll rate proportional Gain. // @Description This defines how much the aileron input will be commanded depending on the current body angular rate error. @@ -130,8 +130,6 @@ PARAM_DEFINE_FLOAT(FW_YR_I, 0.0f); // @Increment 0.1 PARAM_DEFINE_FLOAT(FW_YR_IMAX, 0.2f); -PARAM_DEFINE_FLOAT(FW_Y_ROLLFF, 0); //xxx: remove - // @DisplayName Maximum Yaw Rate // @Description This limits the maximum yaw rate the controller will output (in degrees per second). Setting a value of zero disables the limit. // @Range 0 to 90.0 degrees per seconds -- cgit v1.2.3