aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVlad Uspensky <vlad.uspensky@dominodatalab.com>2018-06-25 17:09:43 -0700
committerZach Smith <zach@driver.xyz>2018-06-25 17:09:43 -0700
commit981cc63b94c6df5fc8f4d2f6ebafd1a6f27d7c4e (patch)
tree1ef2ba11719123bf0433dcd9fdb3539cd40deebc
parente292a16a560e6cfec2bf0d1afbd88c3277d21065 (diff)
downloaddriver-core-981cc63b94c6df5fc8f4d2f6ebafd1a6f27d7c4e.tar.gz
driver-core-981cc63b94c6df5fc8f4d2f6ebafd1a6f27d7c4e.tar.bz2
driver-core-981cc63b94c6df5fc8f4d2f6ebafd1a6f27d7c4e.zip
Info level short logging for requests and responses our services receive (#165)
* Info level short logging for requests and responses our services receive * Remove STDOUT_DEBUG from deployed-logback.xml
-rw-r--r--src/main/resources/deployed-logback.xml1
-rw-r--r--src/main/scala/xyz/driver/core/app/DriverApp.scala19
2 files changed, 15 insertions, 5 deletions
diff --git a/src/main/resources/deployed-logback.xml b/src/main/resources/deployed-logback.xml
index 6518596..b626b4b 100644
--- a/src/main/resources/deployed-logback.xml
+++ b/src/main/resources/deployed-logback.xml
@@ -79,7 +79,6 @@
</encoder>
</appender>
<root level="DEBUG">
- <appender-ref ref="STDOUT_DEBUG" />
<appender-ref ref="STDOUT_INFO" />
<appender-ref ref="STDERR_WARN" />
<appender-ref ref="STDERR_ERROR" />
diff --git a/src/main/scala/xyz/driver/core/app/DriverApp.scala b/src/main/scala/xyz/driver/core/app/DriverApp.scala
index 56ee898..6dd98e3 100644
--- a/src/main/scala/xyz/driver/core/app/DriverApp.scala
+++ b/src/main/scala/xyz/driver/core/app/DriverApp.scala
@@ -139,7 +139,7 @@ class DriverApp(
storeRequestContextToMdc(ctx.request, origin, ip)
- log.debug(s"""Received request {"method":"${ctx.request.method.value}","url": "${ctx.request.uri}"}""")
+ log.info(s"""Received request ${ctx.request.method.value} ${ctx.request.uri} (trace: $trackingId)""")
val contextWithTrackingId =
ctx.withRequest(
@@ -147,9 +147,20 @@ class DriverApp(
.addHeader(RawHeader(ContextHeaders.TrackingIdHeader, trackingId))
.addHeader(RawHeader(ContextHeaders.StacktraceHeader, updatedStacktrace)))
- respondWithAllCorsHeaders {
- combinedRoute
- }(contextWithTrackingId)
+ val logResponses = mapRouteResult {
+ case c @ Complete(response) =>
+ log.info(
+ s"Responded to ${ctx.request.method.value} ${ctx.request.uri} " +
+ s"with ${response.status.toString} (trace: $trackingId)")
+ c
+ case r @ Rejected(rejections) =>
+ log.warn(
+ s"Request ${ctx.request.method.value} ${ctx.request.uri} " +
+ s"(trace: $trackingId) is rejected:\n${rejections.mkString(",\n")}")
+ r
+ }
+
+ respondWithAllCorsHeaders(logResponses(combinedRoute))(contextWithTrackingId)
}
}