diff options
| author | Guillaume Martres <smarter@ubuntu.com> | 2016-06-02 18:08:33 +0200 |
|---|---|---|
| committer | Guillaume Martres <smarter@ubuntu.com> | 2016-06-02 19:01:20 +0200 |
| commit | 35abf29456a7b5b6fa7f114917990cb228e66be9 (patch) | |
| tree | c3fbf6e16509946fac0b1516da5c47ac3fa7e848 | |
| parent | 845b98186047f38013e2f6aa35508e974eedafb7 (diff) | |
| download | dotty-35abf29456a7b5b6fa7f114917990cb228e66be9.tar.gz dotty-35abf29456a7b5b6fa7f114917990cb228e66be9.tar.bz2 dotty-35abf29456a7b5b6fa7f114917990cb228e66be9.zip | |
Properly report errors when cli flags are malformed
Previously we returned an empty Reporter with no errors so partest
reported the test as a success.
| -rw-r--r-- | src/dotty/tools/dotc/Driver.scala | 2 | ||||
| -rw-r--r-- | test/dotc/tests.scala | 3 | ||||
| -rw-r--r-- | tests/neg/customArgs/cliError.scala | 2 |
3 files changed, 6 insertions, 1 deletions
diff --git a/src/dotty/tools/dotc/Driver.scala b/src/dotty/tools/dotc/Driver.scala index 2e78854c1..f54a23ad2 100644 --- a/src/dotty/tools/dotc/Driver.scala +++ b/src/dotty/tools/dotc/Driver.scala @@ -31,7 +31,7 @@ abstract class Driver extends DotClass { ctx.error(ex.getMessage) // signals that we should fail compilation. ctx.reporter } - else emptyReporter + else ctx.reporter protected def initCtx = (new ContextBase).initialCtx diff --git a/test/dotc/tests.scala b/test/dotc/tests.scala index d43c5059b..bac443735 100644 --- a/test/dotc/tests.scala +++ b/test/dotc/tests.scala @@ -119,6 +119,9 @@ class tests extends CompilerTest { @Test def neg_typedIdents() = compileDir(negDir, "typedIdents") val negCustomArgs = negDir + "customArgs/" + + @Test def neg_cli_error = compileFile(negCustomArgs, "cliError", List("-thisOptionDoesNotExist")) + @Test def neg_typers() = compileFile(negCustomArgs, "typers")(allowDoubleBindings) @Test def neg_overrideClass = compileFile(negCustomArgs, "overrideClass", scala2mode) @Test def neg_autoTupling = compileFile(negCustomArgs, "autoTuplingTest", args = "-language:noAutoTupling" :: Nil) diff --git a/tests/neg/customArgs/cliError.scala b/tests/neg/customArgs/cliError.scala new file mode 100644 index 000000000..b2f0f6cdc --- /dev/null +++ b/tests/neg/customArgs/cliError.scala @@ -0,0 +1,2 @@ +// nopos-error +object Test |