diff options
| author | Olivier Blanvillain <olivier.blanvillain@gmail.com> | 2017-04-13 09:18:46 +0200 |
|---|---|---|
| committer | Olivier Blanvillain <olivier.blanvillain@gmail.com> | 2017-04-13 10:39:29 +0200 |
| commit | 3e04b6f3aa4e4088220f199bd6aa5c6644c22354 (patch) | |
| tree | c2b1a480a11ea6b23b2bc2f1b322203a8425c4da /compiler/src/dotty/tools/dotc/transform/PatternMatcher.scala | |
| parent | 3a9deec8e7a3a093e9b56461650857c4cb7a9d8c (diff) | |
| download | dotty-3e04b6f3aa4e4088220f199bd6aa5c6644c22354.tar.gz dotty-3e04b6f3aa4e4088220f199bd6aa5c6644c22354.tar.bz2 dotty-3e04b6f3aa4e4088220f199bd6aa5c6644c22354.zip | |
Revert <: Product requierment in pattern matching
The change in question broke the following pattern, commonly used in name based pattern matching:
```scala
object ProdEmpty {
def _1: Int = ???
def _2: String = ???
def isEmpty = true
def get = this
}
```
This type define both `_1` and `get` + `isEmpty` (but is not <: Product). After #1938, `ProdEmpty` became eligibles for both product and name based pattern. Because "in case of ambiguities, *Product Pattern* is preferred over *Name Based Pattern*", isEmpty wouldn't be used, breaking the scalac semantics.
Diffstat (limited to 'compiler/src/dotty/tools/dotc/transform/PatternMatcher.scala')
| -rw-r--r-- | compiler/src/dotty/tools/dotc/transform/PatternMatcher.scala | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/compiler/src/dotty/tools/dotc/transform/PatternMatcher.scala b/compiler/src/dotty/tools/dotc/transform/PatternMatcher.scala index 41a1218eb..447a003e7 100644 --- a/compiler/src/dotty/tools/dotc/transform/PatternMatcher.scala +++ b/compiler/src/dotty/tools/dotc/transform/PatternMatcher.scala @@ -1408,7 +1408,7 @@ class PatternMatcher extends MiniPhaseTransform with DenotTransformer { protected def seqTree(binder: Symbol) = tupleSel(binder)(firstIndexingBinder + 1) protected def tupleSel(binder: Symbol)(i: Int): Tree = { val accessors = - if (Applications.canProductMatch(binder.info)) + if (defn.isProductSubType(binder.info)) productSelectors(binder.info) else binder.caseAccessors val res = |