Selective caching of SelectionProtos and ViewProtos

We cache SelectionProtos if their "compat" parameter is "NoViewsAllowed". We always cache ViewProtos.

That's important for implicit search, because this enables eligible refs to be better cached. To make this work, we add a case to WildApprox which massages SelectionProtos so they also get noViewsAllowed in the compat parameter.

1 files changed, 4 insertions, 2 deletions

diff --git a/src/dotty/tools/dotc/core/Hashable.scala b/src/dotty/tools/dotc/core/Hashable.scala
index 2f55ef70a..fc3b7d0c7 100644
--- a/src/dotty/tools/dotc/core/Hashable.scala
+++ b/src/dotty/tools/dotc/core/Hashable.scala
@@ -35,8 +35,6 @@ trait Hashable {
 
   protected final def identityHash = avoidNotCached(System.identityHashCode(this))
 
-  protected final def avoidNotCached(h: Int) = if (h == NotCached) NotCachedAlt else h
-
   private def finishHash(seed: Int, arity: Int, tp: Type): Int = {
     val elemHash = tp.hash
     if (elemHash == NotCached) return NotCached
@@ -89,4 +87,8 @@ trait Hashable {
 
   protected final def doHash(x1: Any, tp2: Type, tps3: List[Type]): Int =
     finishHash(hashing.mix(hashSeed, x1.hashCode), 1, tp2, tps3)
+
+  protected final def addDelta(hc: Int, delta: Int) = avoidNotCached(hc + delta)
+
+  private def avoidNotCached(h: Int) = if (h == NotCached) NotCachedAlt else h
 }