diff options
author | Martin Odersky <odersky@gmail.com> | 2017-01-29 17:54:30 +1100 |
---|---|---|
committer | Guillaume Martres <smarter@ubuntu.com> | 2017-01-29 14:44:30 +0100 |
commit | 56fb15888fb98e3a6a535f5734bb8ce82fcd76c3 (patch) | |
tree | c1e01cce8a76a5e66ba2a54472bc899ae41ca405 /tests/neg/i1750a.scala | |
parent | 6e8933ccc40bbfe1a92c32c2d8314fd6facef12a (diff) | |
download | dotty-56fb15888fb98e3a6a535f5734bb8ce82fcd76c3.tar.gz dotty-56fb15888fb98e3a6a535f5734bb8ce82fcd76c3.tar.bz2 dotty-56fb15888fb98e3a6a535f5734bb8ce82fcd76c3.zip |
Fix #1750: Handle illegal class overrides better
Illegal class overrides are fundamentally at odds with the way dotty
represents types and therefore can cause lots of low-level problems.
Two measures in this commit
First, we detect direct illegal class overrides on completion instead of
during RefChecks. Break the override by making the previously
overriding type private.
This fixes i1750.scala, but still fails for indirect overrides between
two unrelated outer traits/classes that are inherited by the same class or trait.
We fix this by catching the previously thrown ClassCastException
in both ExtractAPI and RefChecks.
Test case for indirect overrides is in i1750a.scala.
Diffstat (limited to 'tests/neg/i1750a.scala')
-rw-r--r-- | tests/neg/i1750a.scala | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/tests/neg/i1750a.scala b/tests/neg/i1750a.scala new file mode 100644 index 000000000..cbb5bec95 --- /dev/null +++ b/tests/neg/i1750a.scala @@ -0,0 +1,13 @@ +trait Lang1 { + trait Exp + trait Visitor { def f(left: Exp): Unit } + class Eval1 extends Visitor { self => + def f(left: Exp) = () + } +} +trait Lang3 { self: Lang1 => + class Visitor extends Eval1 { Visitor => // error: classes cannot be overridden + } +} +trait Lang4 extends Lang1 with Lang3 + |