aboutsummaryrefslogtreecommitdiff
path: root/R/check-cran.sh
diff options
context:
space:
mode:
authorFelix Cheung <felixcheung_m@hotmail.com>2016-12-08 11:29:31 -0800
committerShivaram Venkataraman <shivaram@cs.berkeley.edu>2016-12-08 11:29:31 -0800
commitc3d3a9d0e85b834abef87069e4edd27db87fc607 (patch)
treebcb6a0d4e506d6ddce58cf927e2e6b8e85970045 /R/check-cran.sh
parent3c68944b229aaaeeaee3efcbae3e3be9a2914855 (diff)
downloadspark-c3d3a9d0e85b834abef87069e4edd27db87fc607.tar.gz
spark-c3d3a9d0e85b834abef87069e4edd27db87fc607.tar.bz2
spark-c3d3a9d0e85b834abef87069e4edd27db87fc607.zip
[SPARK-18590][SPARKR] build R source package when making distribution
## What changes were proposed in this pull request? This PR has 2 key changes. One, we are building source package (aka bundle package) for SparkR which could be released on CRAN. Two, we should include in the official Spark binary distributions SparkR installed from this source package instead (which would have help/vignettes rds needed for those to work when the SparkR package is loaded in R, whereas earlier approach with devtools does not) But, because of various differences in how R performs different tasks, this PR is a fair bit more complicated. More details below. This PR also includes a few minor fixes. ### more details These are the additional steps in make-distribution; please see [here](https://github.com/apache/spark/blob/master/R/CRAN_RELEASE.md) on what's going to a CRAN release, which is now run during make-distribution.sh. 1. package needs to be installed because the first code block in vignettes is `library(SparkR)` without lib path 2. `R CMD build` will build vignettes (this process runs Spark/SparkR code and captures outputs into pdf documentation) 3. `R CMD check` on the source package will install package and build vignettes again (this time from source packaged) - this is a key step required to release R package on CRAN (will skip tests here but tests will need to pass for CRAN release process to success - ideally, during release signoff we should install from the R source package and run tests) 4. `R CMD Install` on the source package (this is the only way to generate doc/vignettes rds files correctly, not in step # 1) (the output of this step is what we package into Spark dist and sparkr.zip) Alternatively, R CMD build should already be installing the package in a temp directory though it might just be finding this location and set it to lib.loc parameter; another approach is perhaps we could try calling `R CMD INSTALL --build pkg` instead. But in any case, despite installing the package multiple times this is relatively fast. Building vignettes takes a while though. ## How was this patch tested? Manually, CI. Author: Felix Cheung <felixcheung_m@hotmail.com> Closes #16014 from felixcheung/rdist.
Diffstat (limited to 'R/check-cran.sh')
-rwxr-xr-xR/check-cran.sh19
1 files changed, 18 insertions, 1 deletions
diff --git a/R/check-cran.sh b/R/check-cran.sh
index c5f042848c..1288e7fc9f 100755
--- a/R/check-cran.sh
+++ b/R/check-cran.sh
@@ -34,8 +34,9 @@ if [ ! -z "$R_HOME" ]
fi
R_SCRIPT_PATH="$(dirname $(which R))"
fi
-echo "USING R_HOME = $R_HOME"
+echo "Using R_SCRIPT_PATH = ${R_SCRIPT_PATH}"
+# Install the package (this is required for code in vignettes to run when building it later)
# Build the latest docs, but not vignettes, which is built with the package next
$FWDIR/create-docs.sh
@@ -82,4 +83,20 @@ else
# This will run tests and/or build vignettes, and require SPARK_HOME
SPARK_HOME="${SPARK_HOME}" "$R_SCRIPT_PATH/"R CMD check $CRAN_CHECK_OPTIONS SparkR_"$VERSION".tar.gz
fi
+
+# Install source package to get it to generate vignettes rds files, etc.
+if [ -n "$CLEAN_INSTALL" ]
+then
+ echo "Removing lib path and installing from source package"
+ LIB_DIR="$FWDIR/lib"
+ rm -rf $LIB_DIR
+ mkdir -p $LIB_DIR
+ "$R_SCRIPT_PATH/"R CMD INSTALL SparkR_"$VERSION".tar.gz --library=$LIB_DIR
+
+ # Zip the SparkR package so that it can be distributed to worker nodes on YARN
+ pushd $LIB_DIR > /dev/null
+ jar cfM "$LIB_DIR/sparkr.zip" SparkR
+ popd > /dev/null
+fi
+
popd > /dev/null