diff options
| author | tedyu <yuzhihong@gmail.com> | 2016-02-10 10:58:41 +0000 |
|---|---|---|
| committer | Sean Owen <sowen@cloudera.com> | 2016-02-10 10:58:41 +0000 |
| commit | e834e421dec30be8dade21287165d5eb95411c73 (patch) | |
| tree | 398bc3552796a13e53efd557cfc926a49402644e /scalastyle-config.xml | |
| parent | 2ba9b6a2dfff8eb06b6f93024f5140e784b8be49 (diff) | |
| download | spark-e834e421dec30be8dade21287165d5eb95411c73.tar.gz spark-e834e421dec30be8dade21287165d5eb95411c73.tar.bz2 spark-e834e421dec30be8dade21287165d5eb95411c73.zip | |
[SPARK-13203] Add scalastyle rule banning use of mutable.SynchronizedBuffer
andrewor14
Please take a look
Author: tedyu <yuzhihong@gmail.com>
Closes #11134 from tedyu/master.
Diffstat (limited to 'scalastyle-config.xml')
| -rw-r--r-- | scalastyle-config.xml | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/scalastyle-config.xml b/scalastyle-config.xml index 967a482ba4..64619d2108 100644 --- a/scalastyle-config.xml +++ b/scalastyle-config.xml @@ -169,6 +169,18 @@ This file is divided into 3 sections: ]]></customMessage> </check> + <check customId="mutablesynchronizedbuffer" level="error" class="org.scalastyle.file.RegexChecker" enabled="true"> + <parameters><parameter name="regex">mutable\.SynchronizedBuffer</parameter></parameters> + <customMessage><![CDATA[ + Are you sure that you want to use mutable.SynchronizedBuffer? In most cases, you should use + java.util.concurrent.ConcurrentLinkedQueue instead. + If you must use mutable.SynchronizedBuffer, wrap the code block with + // scalastyle:off mutablesynchronizedbuffer + mutable.SynchronizedBuffer[...] + // scalastyle:on mutablesynchronizedbuffer + ]]></customMessage> + </check> + <check customId="classforname" level="error" class="org.scalastyle.file.RegexChecker" enabled="true"> <parameters><parameter name="regex">Class\.forName</parameter></parameters> <customMessage><![CDATA[ |