diff options
| author | Josh Rosen <joshrosen@databricks.com> | 2016-03-10 23:28:34 -0800 |
|---|---|---|
| committer | Josh Rosen <joshrosen@databricks.com> | 2016-03-10 23:28:34 -0800 |
| commit | 6ca990fb366cf68cd9d5afb433725d28f07e51a0 (patch) | |
| tree | 036d4b8afc9f8f14f95e5f31e92cabcd51850242 /tools/pom.xml | |
| parent | d18276cb1d82790a402960835e112aebd0c55513 (diff) | |
| download | spark-6ca990fb366cf68cd9d5afb433725d28f07e51a0.tar.gz spark-6ca990fb366cf68cd9d5afb433725d28f07e51a0.tar.bz2 spark-6ca990fb366cf68cd9d5afb433725d28f07e51a0.zip | |
[SPARK-13294][PROJECT INFRA] Remove MiMa's dependency on spark-class / Spark assembly
This patch removes the need to build a full Spark assembly before running the `dev/mima` script.
- I modified the `tools` project to remove a direct dependency on Spark, so `sbt/sbt tools/fullClasspath` will now return the classpath for the `GenerateMIMAIgnore` class itself plus its own dependencies.
- This required me to delete two classes full of dead code that we don't use anymore
- `GenerateMIMAIgnore` now uses [ClassUtil](http://software.clapper.org/classutil/) to find all of the Spark classes rather than our homemade JAR traversal code. The problem in our own code was that it didn't handle folders of classes properly, which is necessary in order to generate excludes with an assembly-free Spark build.
- `./dev/mima` no longer runs through `spark-class`, eliminating the need to reason about classpath ordering between `SPARK_CLASSPATH` and the assembly.
Author: Josh Rosen <joshrosen@databricks.com>
Closes #11178 from JoshRosen/remove-assembly-in-run-tests.
Diffstat (limited to 'tools/pom.xml')
| -rw-r--r-- | tools/pom.xml | 15 |
1 files changed, 5 insertions, 10 deletions
diff --git a/tools/pom.xml b/tools/pom.xml index b3a5ae2771..9bb20e1381 100644 --- a/tools/pom.xml +++ b/tools/pom.xml @@ -35,16 +35,6 @@ <dependencies> <dependency> - <groupId>org.apache.spark</groupId> - <artifactId>spark-core_${scala.binary.version}</artifactId> - <version>${project.version}</version> - </dependency> - <dependency> - <groupId>org.apache.spark</groupId> - <artifactId>spark-streaming_${scala.binary.version}</artifactId> - <version>${project.version}</version> - </dependency> - <dependency> <groupId>org.scala-lang</groupId> <artifactId>scala-reflect</artifactId> </dependency> @@ -52,6 +42,11 @@ <groupId>org.scala-lang</groupId> <artifactId>scala-compiler</artifactId> </dependency> + <dependency> + <groupId>org.clapper</groupId> + <artifactId>classutil_${scala.binary.version}</artifactId> + <version>1.0.6</version> + </dependency> </dependencies> <build> |