aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJohn St John <johnthesaintjohn@gmail.com>2017-09-26 17:16:10 -0700
committerJohn St John <johnthesaintjohn@gmail.com>2017-09-26 17:16:10 -0700
commit77d464e2db5a46319b3687db2353120fddaab097 (patch)
treef6de3b581df821a43894f1b2c5ab659e67a1846d
parentc1628abaad79de60c7eafb27a5914dabd3fb75dc (diff)
downloaddriver-core-77d464e2db5a46319b3687db2353120fddaab097.tar.gz
driver-core-77d464e2db5a46319b3687db2353120fddaab097.tar.bz2
driver-core-77d464e2db5a46319b3687db2353120fddaab097.zip
just use a unit size per span
-rw-r--r--src/main/scala/xyz/driver/core/trace/GoogleStackdriverTraceWithConsumer.scala4
-rw-r--r--src/main/scala/xyz/driver/core/trace/UnitTraceSizer.scala7
2 files changed, 9 insertions, 2 deletions
diff --git a/src/main/scala/xyz/driver/core/trace/GoogleStackdriverTraceWithConsumer.scala b/src/main/scala/xyz/driver/core/trace/GoogleStackdriverTraceWithConsumer.scala
index 13b80bb..cd9170a 100644
--- a/src/main/scala/xyz/driver/core/trace/GoogleStackdriverTraceWithConsumer.scala
+++ b/src/main/scala/xyz/driver/core/trace/GoogleStackdriverTraceWithConsumer.scala
@@ -6,7 +6,6 @@ import com.google.cloud.trace.sink.TraceSink
import com.google.cloud.trace.v1.TraceSinkV1
import com.google.cloud.trace.v1.consumer.{SizedBufferingTraceConsumer, TraceConsumer}
import com.google.cloud.trace.v1.producer.TraceProducer
-import com.google.cloud.trace.v1.util.RoughTraceSizer
import com.google.cloud.trace.{SpanContextHandler, SpanContextHandlerTracer, Tracer}
import com.typesafe.scalalogging.Logger
@@ -21,8 +20,9 @@ final class GoogleStackdriverTraceWithConsumer(projectId: String,
extends GoogleServiceTracer {
private val traceProducer: TraceProducer = new TraceProducer()
+ // use a UnitTraceSizer so the interpretation of bufferSize is # of spans to hold in memory prior to flushing
private val threadSafeBufferingTraceConsumer = new ExceptionLoggingFlushableTraceConsumer(
- new SizedBufferingTraceConsumer(traceConsumer, new RoughTraceSizer(), bufferSize),
+ new SizedBufferingTraceConsumer(traceConsumer, new UnitTraceSizer(), bufferSize),
log
)
diff --git a/src/main/scala/xyz/driver/core/trace/UnitTraceSizer.scala b/src/main/scala/xyz/driver/core/trace/UnitTraceSizer.scala
new file mode 100644
index 0000000..a7d6032
--- /dev/null
+++ b/src/main/scala/xyz/driver/core/trace/UnitTraceSizer.scala
@@ -0,0 +1,7 @@
+package xyz.driver.core.trace
+import com.google.cloud.trace.v1.util.Sizer
+import com.google.devtools.cloudtrace.v1.Trace
+
+class UnitTraceSizer extends Sizer[Trace] {
+ override def size(sizeable: Trace) = 1
+}