diff options
author | Ivan Topolnjak <ivantopo@gmail.com> | 2015-04-18 16:11:23 +0200 |
---|---|---|
committer | Ivan Topolnjak <ivantopo@gmail.com> | 2015-04-18 16:11:23 +0200 |
commit | f476985fd26b4be2281bb7e68dc916190c681467 (patch) | |
tree | c9519cd05c46b27d8c78fb1387784da0f9c32d26 /kamon-akka/src/test/scala | |
parent | bf04eba8d967eb432c3ff825228a523f5393c2f1 (diff) | |
download | Kamon-f476985fd26b4be2281bb7e68dc916190c681467.tar.gz Kamon-f476985fd26b4be2281bb7e68dc916190c681467.tar.bz2 Kamon-f476985fd26b4be2281bb7e68dc916190c681467.zip |
= akka: clean up the ask pattern warning instrumentation and tests.
Diffstat (limited to 'kamon-akka/src/test/scala')
-rw-r--r-- | kamon-akka/src/test/scala/kamon/akka/instrumentation/AskPatternInstrumentationSpec.scala | 80 |
1 files changed, 24 insertions, 56 deletions
diff --git a/kamon-akka/src/test/scala/kamon/akka/instrumentation/AskPatternInstrumentationSpec.scala b/kamon-akka/src/test/scala/kamon/akka/instrumentation/AskPatternInstrumentationSpec.scala index 4268e53d..d9fbc2df 100644 --- a/kamon-akka/src/test/scala/kamon/akka/instrumentation/AskPatternInstrumentationSpec.scala +++ b/kamon-akka/src/test/scala/kamon/akka/instrumentation/AskPatternInstrumentationSpec.scala @@ -16,18 +16,16 @@ package kamon.instrumentation.akka -import java.util.concurrent.atomic.AtomicInteger - import akka.actor._ -import akka.event.Logging.Warning import akka.pattern.ask -import akka.testkit.TestProbe +import akka.testkit.EventFilter import akka.util.Timeout import com.typesafe.config.ConfigFactory import kamon.Kamon -import kamon.akka.Akka +import kamon.akka.AskPatternTimeoutWarningSettings.{ Off, Lightweight, Heavyweight } +import kamon.akka.{ AskPatternTimeoutWarningSetting, Akka } import kamon.testkit.BaseKamonSpec -import kamon.trace.{ Tracer, TraceContext, TraceContextAware } +import kamon.trace.Tracer import scala.concurrent.duration._ @@ -37,6 +35,7 @@ class AskPatternInstrumentationSpec extends BaseKamonSpec("ask-pattern-tracing-s """ |akka { | loglevel = OFF + | loggers = [akka.testkit.TestEventListener] |} """.stripMargin) @@ -47,10 +46,11 @@ class AskPatternInstrumentationSpec extends BaseKamonSpec("ask-pattern-tracing-s "the AskPatternInstrumentation" when { "configured in heavyweight mode" should { - "log a warning with a full stack trace and the TraceContext taken from the moment the ask was triggered for a actor" in new NoReplyFixture { - setAskPatternTimeoutWarningMode("heavyweight") + "log a warning with a full stack trace and the TraceContext taken from the moment the ask was triggered for a actor" in { + val noReplyActorRef = system.actorOf(Props[NoReply], "no-reply-1") + setAskPatternTimeoutWarningMode(Heavyweight) - expectTimeoutWarning() { + EventFilter.warning(start = "Timeout triggered for ask pattern to actor [no-reply-1] at").intercept { Tracer.withContext(newContext("ask-timeout-warning")) { noReplyActorRef ? "hello" Tracer.currentContext @@ -60,10 +60,11 @@ class AskPatternInstrumentationSpec extends BaseKamonSpec("ask-pattern-tracing-s } "configured in lightweight mode" should { - "log a warning with a short source location description and the TraceContext taken from the moment the ask was triggered for a actor" in new NoReplyFixture { - setAskPatternTimeoutWarningMode("lightweight") + "log a warning with a short source location description and the TraceContext taken from the moment the ask was triggered for a actor" in { + val noReplyActorRef = system.actorOf(Props[NoReply], "no-reply-2") + setAskPatternTimeoutWarningMode(Lightweight) - expectTimeoutWarning(messageSizeLimit = Some(1)) { + EventFilter.warning(start = "Timeout triggered for ask pattern to actor [no-reply-2] at").intercept { Tracer.withContext(newContext("ask-timeout-warning")) { noReplyActorRef ? "hello" Tracer.currentContext @@ -73,13 +74,16 @@ class AskPatternInstrumentationSpec extends BaseKamonSpec("ask-pattern-tracing-s } "configured in off mode" should { - "should not log any warning messages" in new NoReplyFixture { - setAskPatternTimeoutWarningMode("off") - - expectTimeoutWarning(expectWarning = false) { - Tracer.withContext(newContext("ask-timeout-warning")) { - noReplyActorRef ? "hello" - Tracer.currentContext + "should not log any warning messages" in { + val noReplyActorRef = system.actorOf(Props[NoReply], "no-reply-3") + setAskPatternTimeoutWarningMode(Off) + + intercept[AssertionError] { // No message will be logged and the event filter will fail. + EventFilter.warning(start = "Timeout triggered for ask pattern to actor", occurrences = 1).intercept { + Tracer.withContext(newContext("ask-timeout-warning")) { + noReplyActorRef ? "hello" + Tracer.currentContext + } } } } @@ -88,48 +92,12 @@ class AskPatternInstrumentationSpec extends BaseKamonSpec("ask-pattern-tracing-s override protected def afterAll(): Unit = shutdown() - def expectTimeoutWarning(messageSizeLimit: Option[Int] = None, expectWarning: Boolean = true)(thunk: ⇒ TraceContext): Unit = { - val listener = warningListener() - val testTraceContext = thunk - - if (expectWarning) { - val warning = listener.fishForMessage() { - case Warning(_, _, msg) if msg.toString.startsWith("Timeout triggered for ask pattern registered at") ⇒ true - case others ⇒ false - }.asInstanceOf[Warning] - - warning.asInstanceOf[TraceContextAware].traceContext should equal(testTraceContext) - messageSizeLimit.map { messageLimit ⇒ - warning.message.toString.lines.size should be(messageLimit) - } - } else { - listener.expectNoMsg() - } - } - - def warningListener(): TestProbe = { - val listener = TestProbe() - system.eventStream.subscribe(listener.ref, classOf[Warning]) - listener - } - - def setAskPatternTimeoutWarningMode(mode: String): Unit = { + def setAskPatternTimeoutWarningMode(mode: AskPatternTimeoutWarningSetting): Unit = { val target = Kamon(Akka) val field = target.getClass.getDeclaredField("askPatternTimeoutWarning") field.setAccessible(true) field.set(target, mode) } - - val fixtureCounter = new AtomicInteger(0) - - trait NoReplyFixture { - def noReplyActorRef: ActorRef = system.actorOf(Props[NoReply], "no-reply-" + fixtureCounter.incrementAndGet()) - - def noReplyActorSelection: ActorSelection = { - val target = noReplyActorRef - system.actorSelection(target.path) - } - } } class NoReply extends Actor { |