diff options
| author | mladens <mladens42@gmail.com> | 2017-07-12 12:26:38 +0200 |
|---|---|---|
| committer | mladens <mladens42@gmail.com> | 2017-07-12 12:26:38 +0200 |
| commit | 6c0a8fb6395fca11b48f7ad1cd2bd774f90ee7fd (patch) | |
| tree | 11cfe2100a59ab6af800293707ab6266dd2195ec /kamon-core | |
| parent | 09af20cca6243400e0b922113d896e1ddc46382c (diff) | |
| download | Kamon-6c0a8fb6395fca11b48f7ad1cd2bd774f90ee7fd.tar.gz Kamon-6c0a8fb6395fca11b48f7ad1cd2bd774f90ee7fd.tar.bz2 Kamon-6c0a8fb6395fca11b48f7ad1cd2bd774f90ee7fd.zip | |
Remove span error counter, count from metric refined with error tag should be used
Diffstat (limited to 'kamon-core')
| -rw-r--r-- | kamon-core/src/main/scala/kamon/trace/Span.scala | 1 | ||||
| -rw-r--r-- | kamon-core/src/test/scala/kamon/trace/SpanMetrics.scala | 4 |
2 files changed, 0 insertions, 5 deletions
diff --git a/kamon-core/src/main/scala/kamon/trace/Span.scala b/kamon-core/src/main/scala/kamon/trace/Span.scala index 63cecadc..464559e3 100644 --- a/kamon-core/src/main/scala/kamon/trace/Span.scala +++ b/kamon-core/src/main/scala/kamon/trace/Span.scala @@ -158,7 +158,6 @@ class Span(spanContext: SpanContext, initialOperationName: String, initialTags: } val refinedTags = if(isError) { - Span.Metrics.SpanErrorCount.refine(metricTags).increment() metricTags + ("error" -> Span.BooleanTagTrueValue) } else { metricTags diff --git a/kamon-core/src/test/scala/kamon/trace/SpanMetrics.scala b/kamon-core/src/test/scala/kamon/trace/SpanMetrics.scala index 6f32e000..a4ce9882 100644 --- a/kamon-core/src/test/scala/kamon/trace/SpanMetrics.scala +++ b/kamon-core/src/test/scala/kamon/trace/SpanMetrics.scala @@ -26,8 +26,6 @@ class SpanMetrics extends WordSpecLike with Matchers { val errorHistogram = histogramMetric.refine(operationTag, errorTag).distribution() errorHistogram.count === 0 - val errorCount = histogramMetric.refine(operationTag, errorTag).distribution() - errorCount === 0 } "record correctly error latency and count" in { @@ -44,8 +42,6 @@ class SpanMetrics extends WordSpecLike with Matchers { val errorHistogram = histogramMetric.refine(operationTag, errorTag).distribution() errorHistogram.count === 1 - val errorCount = histogramMetric.refine(operationTag, errorTag).distribution() - errorCount === 1 } } |