aboutsummaryrefslogtreecommitdiff
path: root/kamon-datadog/src/test/scala
diff options
context:
space:
mode:
authorIvan Topolnjak <ivantopo@gmail.com>2014-07-10 20:53:39 -0300
committerIvan Topolnjak <ivantopo@gmail.com>2014-07-10 20:53:39 -0300
commit9d81b6cf128859030f393c07a7d08abc464acbcf (patch)
treee896733d882501541ff83bd76b23d8e83b1e24fc /kamon-datadog/src/test/scala
parent3686990509d004b53f5c069a5353d0484556eb2e (diff)
downloadKamon-9d81b6cf128859030f393c07a7d08abc464acbcf.tar.gz
Kamon-9d81b6cf128859030f393c07a7d08abc464acbcf.tar.bz2
Kamon-9d81b6cf128859030f393c07a7d08abc464acbcf.zip
! statsd,datadog: reformat metric names to get a better display of automatically named traces, closes #35
After a bit of testing it seems like instead of generating more friendly names by default, we need to do changes that are specific to each module (StatsD and Datadog) in order to make it work properly. Here is a list of the introduced changes: - StatsD - Change dots (.) to underscores (_) on the host name string. - Change ': ' to single underscore and spaced to underscore. Userful for automatically generated http trace names. - Change '/' to underscore. Ideally the dashboard could replace '_' with '/' to display it like a path. - Datadog - Change ': ' to ':'. Userful for automatically generated http trace names.
Diffstat (limited to 'kamon-datadog/src/test/scala')
-rw-r--r--kamon-datadog/src/test/scala/kamon/datadog/DatadogMetricSenderSpec.scala15
1 files changed, 13 insertions, 2 deletions
diff --git a/kamon-datadog/src/test/scala/kamon/datadog/DatadogMetricSenderSpec.scala b/kamon-datadog/src/test/scala/kamon/datadog/DatadogMetricSenderSpec.scala
index 91b503e2..713db30d 100644
--- a/kamon-datadog/src/test/scala/kamon/datadog/DatadogMetricSenderSpec.scala
+++ b/kamon-datadog/src/test/scala/kamon/datadog/DatadogMetricSenderSpec.scala
@@ -30,8 +30,19 @@ import java.net.InetSocketAddress
import com.typesafe.config.ConfigFactory
class DatadogMetricSenderSpec extends TestKitBase with WordSpecLike with Matchers {
- implicit lazy val system = ActorSystem("datadog-metric-sender-spec",
- ConfigFactory.parseString("kamon.datadog.max-packet-size = 256 bytes"))
+ implicit lazy val system: ActorSystem = ActorSystem("datadog-metric-sender-spec", ConfigFactory.parseString(
+ """
+ |kamon {
+ | metrics {
+ | disable-aspectj-weaver-missing-error = true
+ | }
+ |
+ | datadog {
+ | max-packet-size = 256 bytes
+ | }
+ |}
+ |
+ """.stripMargin))
val collectionContext = Kamon(Metrics).buildDefaultCollectionContext