aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJan Christopher Vogt <oss.nsp@cvogt.org>2016-09-28 10:29:30 -0400
committerGitHub <noreply@github.com>2016-09-28 10:29:30 -0400
commit816a2cd3c5e67ceb442d40586566b9f8fd363b79 (patch)
treeda89d2721eb9400aa43cc6fab39a3c2fc43eaa0f
parent72bf7175808d40fb962ef1df77e14e777ef54548 (diff)
parentd0cbd2c5afe092c85da7099ab052f700cfc24541 (diff)
downloadcbt-816a2cd3c5e67ceb442d40586566b9f8fd363b79.tar.gz
cbt-816a2cd3c5e67ceb442d40586566b9f8fd363b79.tar.bz2
cbt-816a2cd3c5e67ceb442d40586566b9f8fd363b79.zip
Merge pull request #240 from cvogt/refactorings
Refactorings
-rw-r--r--stage2/BasicBuild.scala7
-rw-r--r--stage2/Lib.scala8
-rw-r--r--stage2/PackageJars.scala2
3 files changed, 9 insertions, 8 deletions
diff --git a/stage2/BasicBuild.scala b/stage2/BasicBuild.scala
index b2bb72b..bcc3646 100644
--- a/stage2/BasicBuild.scala
+++ b/stage2/BasicBuild.scala
@@ -57,7 +57,7 @@ trait BaseBuild extends DependencyImplementation with BuildInterface with Trigge
/** directory where jars (and the pom file) should be put */
def jarTarget: File = scalaTarget
/** directory where the scaladoc should be put */
- def apiTarget: File = scalaTarget ++ "/api"
+ def docTarget: File = scalaTarget ++ "/api"
/** directory where the class files should be put (in package directories) */
def compileTarget: File = scalaTarget ++ "/classes"
/**
@@ -104,7 +104,8 @@ trait BaseBuild extends DependencyImplementation with BuildInterface with Trigge
override def dependencyClasspath : ClassPath = ClassPath(localJars) ++ super.dependencyClasspath
protected def compileDependencies: Seq[Dependency] = Nil
- final def compileClasspath : ClassPath = ClassPath( compileDependencies.flatMap(_.exportedClasspath.files).distinct )
+ final def compileClasspath : ClassPath =
+ dependencyClasspath ++ ClassPath( compileDependencies.flatMap(_.exportedClasspath.files).distinct )
def exportedClasspath : ClassPath = ClassPath(compile.toSeq)
def targetClasspath = ClassPath(Seq(compileTarget))
@@ -129,7 +130,7 @@ trait BaseBuild extends DependencyImplementation with BuildInterface with Trigge
lib.compile(
context.cbtHasChanged,
needsUpdate || context.parentBuild.map(_.needsUpdate).getOrElse(false),
- sourceFiles, compileTarget, compileStatusFile, dependencyClasspath ++ compileClasspath,
+ sourceFiles, compileTarget, compileStatusFile, compileClasspath,
context.paths.mavenCache, scalacOptions, context.classLoaderCache,
zincVersion = zincVersion, scalaVersion = scalaVersion
)
diff --git a/stage2/Lib.scala b/stage2/Lib.scala
index e983a97..46fecf7 100644
--- a/stage2/Lib.scala
+++ b/stage2/Lib.scala
@@ -74,7 +74,7 @@ final class Lib(logger: Logger) extends Stage1Lib(logger) with Scaffold{
scalaVersion: String,
sourceFiles: Seq[File],
dependencyClasspath: ClassPath,
- apiTarget: File,
+ docTarget: File,
jarTarget: File,
artifactId: String,
scalaMajorVersion: String,
@@ -86,11 +86,11 @@ final class Lib(logger: Logger) extends Stage1Lib(logger) with Scaffold{
if(sourceFiles.isEmpty){
None
} else {
- apiTarget.mkdirs
+ docTarget.mkdirs
val args = Seq(
// FIXME: can we use compiler dependency here?
"-cp", dependencyClasspath.string, // FIXME: does this break for builds that don't have scalac dependencies?
- "-d", apiTarget.toString
+ "-d", docTarget.toString
) ++ compileArgs ++ sourceFiles.map(_.toString)
logger.lib("creating docs for source files "+args.mkString(", "))
redirectOutToErr{
@@ -102,7 +102,7 @@ final class Lib(logger: Logger) extends Stage1Lib(logger) with Scaffold{
}
lib.jarFile(
jarTarget ++ ("/"++artifactId++"_"++scalaMajorVersion++"-"++version++"-javadoc.jar"),
- Vector(apiTarget)
+ Vector(docTarget)
)
}
}
diff --git a/stage2/PackageJars.scala b/stage2/PackageJars.scala
index 05e625b..10e4c3a 100644
--- a/stage2/PackageJars.scala
+++ b/stage2/PackageJars.scala
@@ -24,7 +24,7 @@ trait PackageJars extends BaseBuild with ArtifactInfo{
def docJar: Option[File] = cacheDocBasicBuild{
lib.docJar(
context.cbtHasChanged,
- scalaVersion, sourceFiles, dependencyClasspath, apiTarget,
+ scalaVersion, sourceFiles, compileClasspath, docTarget,
jarTarget, artifactId, scalaMajorVersion, version,
scalacOptions, context.classLoaderCache, context.paths.mavenCache
)