| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Problem
I notice that the former release 6.36.0 reset the reporter after
check(), which is not enough. In my use case, I would like to use
apply with resetState=false (or simply inPlace), without checking
it before (check method requires compiling every time, but apply
method has cache).
Under such circumstance, if I offer a piece of code with syntax
error, it will throw CompilerException every time even if I
correct it. It’s because the reporter hasn’t been reset.
Solution
Simply add resetReporter before compile will solve the problem.
Signed-off-by: Christopher Coco <ccoco@twitter.com>
RB_ID=871408
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Problem
When you want to use the util-eval for validating the correctness of a small
chunk of code, you have to reset whole state between invocations (flag
resetState=true), which is expensive when you already have a bunch of compiled
and loaded classes. Without this, if one check fails, all subsequent checks
will fail as well, since some errors has been reported previously.
Solution
Scala compiler API allows for resetting just the reporter, so that compiled and
loaded classes can remain for re-usage for next checks.
Result
Public API remains the same, however the internal API has one new synchronized
method resetReporter() which does what is explained in the "Solution" section.
Signed-off-by: Ryan O'Neill <ryano@twitter.com>
RB_ID=859878
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Problem
We've been nagging each other about == vs ===.
Solution
ag -l ' === ' \
./util \
./ostrich \
./finagle \
./twitter-server \
./scrooge \
./twitter-server-internal | \
grep '\.scala' | \
xargs sed -i '' 's/ === / == /'
ag -l ' ===' \
./util \
./ostrich \
./finagle \
./twitter-server \
./scrooge \
./twitter-server-internal | \
grep '\.scala' | \
xargs sed -i '' 's/ ===$/ ==/'
Result
No more === nags in RB
RB_ID=766849
|
|
|
|
|
|
|
| |
There are a lot of warnings when compiling util,
this fixes many of them.
RB_ID=739494
|
|
|
|
|
|
| |
Signed-off-by: Moses Nakamura <mnakamura@twitter.com>
RB_ID=572344
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Problem
specs is deprecated and throws a fair number of NullPointerExceptions in scala 2.10
Also all of our tests are disabled in scala 2.10 for sbt
Solution
Port all our tests to scalatest
This is based off of this PR: https://github.com/twitter/util/pull/97
Result
Tests pass
RB_ID=397681
|
|
|
|
|
|
|
|
| |
The Scala compiler propagates warnings through exceptions. So Eval
failed if an Eval'ed file uses something deprecated. Disable
warnings.
RB_ID=63167
|
| |
|
| |
|
|
|
|
| |
Also, git-review bump
|
|
|
|
| |
specified via system property
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
commit faf3d257e7dc95d1492b7c8c6faf9da3c53adac6
Merge: d2ecdbd 53fdb61
Author: mmcbride <mccv@twitter.com>
Date: Mon Aug 8 22:05:09 2011 -0700
Merge branch 'master' into persistent_eval
commit d2ecdbddd288607cd1fb597ba04685628ad8b2f0
Author: mmcbride <mccv@twitter.com>
Date: Mon Aug 8 21:40:32 2011 -0700
two minor things from jeremy cloud
commit a17260bd1cd90bab0ac635e0257a9bea8e9da62f
Merge: 5f26ee0 e8d277e
Author: mmcbride <mccv@twitter.com>
Date: Wed Aug 3 20:16:06 2011 -0700
Merge branch 'master' into persistent_eval
commit 5f26ee0544ad39439c509e8b87e60c4cff0f07b9
Author: mmcbride <mccv@twitter.com>
Date: Wed Aug 3 20:13:33 2011 -0700
feedback from RB
commit 775c8661f485724af3be51be720b821b83b044ec
Merge: 350c313 f7d1db2
Author: mmcbride <mccv@twitter.com>
Date: Tue Jul 26 12:41:00 2011 -0700
Merge branch 'master' into persistent_eval
commit 350c313991b31f9e332753a62ff5b92c61ce7cae
Author: mmcbride <mccv@twitter.com>
Date: Tue Jul 26 10:58:25 2011 -0700
persistent compilation targets for eval
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
commit 86a7f2fdac93924da81f4fe7542228f071dbe617
Author: Arya Asemanfar <arya@twitter.com>
Date: Fri Jun 17 11:42:44 2011 -0700
Added test for Eval.toSource
commit d13c269c39514b3a20812bc594cc67a0902d248b
Merge: 294e5d9 ede4550
Author: Arya Asemanfar <arya@twitter.com>
Date: Fri Jun 17 10:42:02 2011 -0700
Merge branch 'master' into tfe/config_post_processing
commit 294e5d982716ec31dddb18b71caea92580aaddb0
Author: Arya Asemanfar <arya@twitter.com>
Date: Thu Jun 16 16:22:41 2011 -0700
Make the config in the dashboard be post-processed config
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
commit ead2b12ebf8c8c9b0d191235119cea7be01a22e8
Author: wilhelm bierbaum <wilhelm@twitter.com>
Date: Fri Apr 29 13:20:37 2011 -0700
use StreamIO
commit 23a12f4b8c40facaad4a81a363d02a3914897267
Merge: 59da183 90a1dd0
Author: wilhelm bierbaum <wilhelm@twitter.com>
Date: Fri Apr 29 13:20:16 2011 -0700
Merge remote-tracking branch 'origin/master' into eval_include_directives
commit 59da18308707f6d285e4b65e7e7a33aa62af77ab
Merge: 4296624 f6ead9a
Author: wilhelm bierbaum <wilhelm@twitter.com>
Date: Thu Apr 28 23:58:18 2011 -0700
Merge remote-tracking branch 'origin/master' into eval_include_directives
Conflicts:
util/util-eval/src/test/scala/com/twitter/util/EvaluatorSpec.scala
commit 42966245dc24d2026a8b3955e3c313445a93ac3e
Merge: a0aa60e d98d9c9
Author: Wilhelm Bierbaum <wilhelm@twitter.com>
Date: Tue Apr 19 20:05:57 2011 -0700
Merge branch 'master' into eval_include_directives
commit a0aa60e80df3bd0312f3349eed61e997109fa510
Author: Wilhelm Bierbaum <wilhelm@twitter.com>
Date: Tue Apr 19 20:05:46 2011 -0700
revert inadvertent changes
commit 931be4dce6dd82ec2ef8d09f8576c9a27f50640a
Author: Wilhelm Bierbaum <wilhelm@twitter.com>
Date: Tue Apr 19 17:10:19 2011 -0700
introduce a preprocessor that can #include files from the filesystem (by default rooted in ./ or ./config) or the classpath into the Eval-based config compiler
|
|
|
|
|
|
|
|
| |
EvalSpec.scala:
Rename, update for new API. Note one test fails (commented out)
Future.scala, ScribeHandlerSpec.scala:
Fix warnings
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
- use test resources when testing, not paths relative to project root
|
| |
|
|
|