diff options
author | Olivier Blanvillain <olivier.blanvillain@gmail.com> | 2017-04-13 09:18:46 +0200 |
---|---|---|
committer | Olivier Blanvillain <olivier.blanvillain@gmail.com> | 2017-04-13 10:39:29 +0200 |
commit | 3e04b6f3aa4e4088220f199bd6aa5c6644c22354 (patch) | |
tree | c2b1a480a11ea6b23b2bc2f1b322203a8425c4da /compiler/src/dotty/tools/dotc/core | |
parent | 3a9deec8e7a3a093e9b56461650857c4cb7a9d8c (diff) | |
download | dotty-3e04b6f3aa4e4088220f199bd6aa5c6644c22354.tar.gz dotty-3e04b6f3aa4e4088220f199bd6aa5c6644c22354.tar.bz2 dotty-3e04b6f3aa4e4088220f199bd6aa5c6644c22354.zip |
Revert <: Product requierment in pattern matching
The change in question broke the following pattern, commonly used in name based pattern matching:
```scala
object ProdEmpty {
def _1: Int = ???
def _2: String = ???
def isEmpty = true
def get = this
}
```
This type define both `_1` and `get` + `isEmpty` (but is not <: Product). After #1938, `ProdEmpty` became eligibles for both product and name based pattern. Because "in case of ambiguities, *Product Pattern* is preferred over *Name Based Pattern*", isEmpty wouldn't be used, breaking the scalac semantics.
Diffstat (limited to 'compiler/src/dotty/tools/dotc/core')
-rw-r--r-- | compiler/src/dotty/tools/dotc/core/Definitions.scala | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/compiler/src/dotty/tools/dotc/core/Definitions.scala b/compiler/src/dotty/tools/dotc/core/Definitions.scala index a97589d73..eee6ba785 100644 --- a/compiler/src/dotty/tools/dotc/core/Definitions.scala +++ b/compiler/src/dotty/tools/dotc/core/Definitions.scala @@ -10,7 +10,6 @@ import scala.collection.{ mutable, immutable } import PartialFunction._ import collection.mutable import util.common.alwaysZero -import typer.Applications object Definitions { @@ -846,6 +845,9 @@ class Definitions { TupleType(elems.size).appliedTo(elems) } + def isProductSubType(tp: Type)(implicit ctx: Context) = + tp.derivesFrom(ProductType.symbol) + /** Is `tp` (an alias) of either a scala.FunctionN or a scala.ImplicitFunctionN? */ def isFunctionType(tp: Type)(implicit ctx: Context) = { val arity = functionArity(tp) |